Skip to content

Add regression test for const generic ICE in #72819 - #73070

Merged
bors merged 4 commits into
rust-lang:masterfrom
ayazhafiz:i/72819
Jun 11, 2020
Merged

Add regression test for const generic ICE in #72819#73070
bors merged 4 commits into
rust-lang:masterfrom
ayazhafiz:i/72819

Conversation

@ayazhafiz

@ayazhafizayazhafiz commented Jun 6, 2020

Copy link
Copy Markdown
Contributor

Closes#72819

@rust-highfive

rust-highfive commented Jun 6, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2020
nikomatsakis
nikomatsakis requested changes Jun 8, 2020
View reviewed changes
Comment threadsrc/test/ui/const-generics/issues/issue-72819-generic-in-const-eval.rs
@nikomatsakisnikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2020
@nikomatsakis

nikomatsakis commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2981395 has been approved by nikomatsakis

@nikomatsakis

nikomatsakis commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2020
@bors
Auto merge ofrust-lang#73206- Dylan-DPC:rollup-rha9g8q, r=Dylan-DPC
ec42485
Rollup of 9 pull requests
Successful merges:
- rust-lang#72706 (Add windows group to triagebot)
- rust-lang#72789 (resolve: Do not suggest imports from the same module in which we are resolving)
- rust-lang#72890 (improper ctypes: normalize return types and transparent structs)
- rust-lang#72897 (normalize adt fields during structural match checking)
- rust-lang#73005 (Don't create impl candidates when obligation contains errors)
- rust-lang#73023 (Remove noisy suggestion of hash_map )
- rust-lang#73070 (Add regression test for const generic ICE in rust-lang#72819)
- rust-lang#73157 (Don't lose empty `where` clause when pretty-printing)
- rust-lang#73184 (Reoder order in which MinGW libs are linked to fix recent breakage)
Failed merges:
r? @ghost
@bors
bors merged commit 0a77c8c into rust-lang:masterJun 11, 2020
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisAwaiting requested review from nikomatsakis

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

ICE on unmonomorphized const generics in const eval: eval_const_to_op: Unexpected ConstKind

5 participants

@ayazhafiz@rust-highfive@nikomatsakis@bors@cuviper