Uh oh!
There was an error while loading. Please reload this page.
Support proc macros in intra doc link resolution - #73183
Merged
Merged
Conversation
rust-highfive
commented
Jun 9, 2020
Contributor
r? @ollie27 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jun 9, 2020
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jun 10, 2020
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
MemberAuthor
Neat bug, pushing a fix now. Interestingly, I tried adding support for stuff like |
Manishearth
commented
Jun 10, 2020
MemberAuthor
| } else if link.starts_with("macro@") { | ||
| kind = Some(MacroNS); | ||
| link.trim_start_matches("macro@") | ||
| } else if link.starts_with("derive@") { |
There was a problem hiding this comment.
I'm wondering: is there any reason behind supporting derive@ too? (Not against it, just curious)
MemberAuthor
There was a problem hiding this comment.
People don't typically consider custom derives to be macros, so asking them to use macro@ seems weird. macro@ still will work (this is true of all of the disambiguators, they don't do anything other than selecting the namespace)
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
left a comment
Member
There was a problem hiding this comment.
Looks good. Just some tests missing and we're good to go!
Manishearth
commented
Jun 10, 2020
MemberAuthor
@bors r=GuillaumeGomez |
bors
commented
Jun 10, 2020
Collaborator
📌 Commit 34c6b38 has been approved by |
bors
commented
Jun 10, 2020
Collaborator
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#72380 (Fix `is_const_context`, update `check_for_cast`) - rust-lang#72941 (Ensure stack when building MIR for matches) - rust-lang#72976 (Clean up E0642 explanation) - rust-lang#73080 (doc/rustdoc: Fix incorrect external_doc feature flag) - rust-lang#73155 (save_analysis: better handle paths and functions signature) - rust-lang#73164 (Add new E0762 error code) - rust-lang#73172 (Fix more clippy warnings) - rust-lang#73181 (Automatically prioritize unsoundness issues) - rust-lang#73183 (Support proc macros in intra doc link resolution) - rust-lang#73208 (Fix doctest template) - rust-lang#73219 (x.py: with --json-output, forward cargo's JSON) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature was written pre-proc macro resolution, so it only supported the wacky MBE resolution rules. This adds support for proc macros as well.
cc @GuillaumeGomez
Fixes#73173