Skip to content

Fix doctest template - #73208

Merged
bors merged 2 commits into
rust-lang:masterfrom
qm3ster:patch-1
Jun 11, 2020
Merged

Fix doctest template#73208
bors merged 2 commits into
rust-lang:masterfrom
qm3ster:patch-1

Conversation

@qm3ster

@qm3sterqm3ster commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

saturating_add example was not parameterized, but passed because the u8 would saturate successfully

@qm3ster
Fix doctest template
5859f6e
`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
@rust-highfive

rust-highfive commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @LukasKalbertodt (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Jun 10, 2020

Copy link
Copy Markdown

r? @Amanieu

@Amanieu

Amanieu commented Jun 10, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5859f6e has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2020
tesuji
tesuji reviewed Jun 11, 2020
View reviewed changes
Comment threadsrc/libcore/num/mod.rs Outdated
@Amanieu@tesuji
Update src/libcore/num/mod.rs
7dc19b0
Co-authored-by: lzutao <taolzu@gmail.com>
@Amanieu

Amanieu commented Jun 11, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7dc19b0 has been approved by Amanieu

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 11, 2020
@RalfJung
Rollup merge ofrust-lang#73208- qm3ster:patch-1, r=Amanieu
a0c75a6
Fix doctest template
`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
@RalfJungRalfJung mentioned this pull request Jun 11, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2020
@bors
Auto merge ofrust-lang#73235- Dylan-DPC:rollup-zp8oxhg, r=Dylan-DPC
50c0192
Rollup of 11 pull requests
Successful merges:
- rust-lang#72380 (Fix `is_const_context`, update `check_for_cast`)
- rust-lang#72941 (Ensure stack when building MIR for matches)
- rust-lang#72976 (Clean up E0642 explanation)
- rust-lang#73080 (doc/rustdoc: Fix incorrect external_doc feature flag)
- rust-lang#73155 (save_analysis: better handle paths and functions signature)
- rust-lang#73164 (Add new E0762 error code)
- rust-lang#73172 (Fix more clippy warnings)
- rust-lang#73181 (Automatically prioritize unsoundness issues)
- rust-lang#73183 (Support proc macros in intra doc link resolution)
- rust-lang#73208 (Fix doctest template)
- rust-lang#73219 (x.py: with --json-output, forward cargo's JSON)
Failed merges:
r? @ghost
@bors
bors merged commit 822bb9a into rust-lang:masterJun 11, 2020
@qm3ster
qm3ster deleted the patch-1 branch June 12, 2020 14:55
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tesujitesujitesuji left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AmanieuAmanieu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

8 participants

@qm3ster@rust-highfive@Dylan-DPC-zz@Amanieu@bors@tesuji@cuviper@LukasKalbertodt