Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #73231
Closed
RalfJung wants to merge 35 commits into
Closed
Conversation
They're unused now.
This is consistent with types.
`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
Co-authored-by: lzutao <taolzu@gmail.com>
…=nikomatsakis Clean up type alias impl trait implementation - Removes special case for top-level impl trait - Removes associated opaque types - Forbid lifetime elision in let position impl trait. This is consistent with the behavior for inferred types. - Handle lifetimes in type alias impl trait more uniformly with other parameters cc rust-lang#69323 cc rust-lang#63063Closesrust-lang#57188Closesrust-lang#62988Closesrust-lang#69136
Fix `is_const_context`, update `check_for_cast` A better version of rust-lang#71477 Adds `fn enclosing_body_owner` and uses it in `is_const_context`. `is_const_context` now uses the same mechanism as `mir_const_qualif` as it was previously incorrect. Renames `is_const_context` to `is_inside_const_context`. I also updated `check_for_cast` in the second commit, so r? @estebank (I removed one lvl of indentation, so it might be easier to review by hiding whitespace changes)
…atthewjasper On recursive ADT, provide indirection structured suggestion
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
…an-DPC Clean up E0642 explanation r? @Dylan-DPC
…_doc-ref-fix, r=ollie27 doc/rustdoc: Fix incorrect external_doc feature flag
…enkov Add new E0762 error code
Automatically prioritize unsoundness issues r? @spastorino cc @Mark-Simulacrum @rust-lang/wg-prioritization
Fix doctest template `saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
x.py: with --json-output, forward cargo's JSON Fixesrust-lang#73209 r? @Mark-Simulacrum
RalfJung
commented
Jun 11, 2020
MemberAuthor
bors
commented
Jun 11, 2020
Collaborator
📌 Commit ef5de43 has been approved by |
bors
commented
Jun 11, 2020
Collaborator
⌛ Testing commit ef5de43 with merge 27235a3cd34a93721b7861388861cf1567163375... |
bors
commented
Jun 11, 2020
Collaborator
💔 Test failed - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_const_context, updatecheck_for_cast#72380 (Fixis_const_context, updatecheck_for_cast)Failed merges:
r? @ghost