Skip to content

Fixing broken link for the Eq trait - #73292

Merged
bors merged 1 commit into
rust-lang:masterfrom
poliorcetics:fix-link-in-partialeq
Jul 10, 2020
Merged

Fixing broken link for the Eq trait#73292
bors merged 1 commit into
rust-lang:masterfrom
poliorcetics:fix-link-in-partialeq

Conversation

@poliorcetics

Copy link
Copy Markdown
Contributor

Fixes#73233.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2020
@poliorcetics

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: T-doc

@rustbotrustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 12, 2020
Comment threadsrc/libcore/cmp.rs
@JohnCSimonJohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2020
@JohnCSimon

Copy link
Copy Markdown

Ping from triage
@poliorcetics - please address the change request from GuillaumeGomez?
Thank you.

@poliorcetics

Copy link
Copy Markdown
ContributorAuthor

The suggested change brings back the bug this PR fixes, except if rustdoc itself has been modified in between.

@Muirrum

Copy link
Copy Markdown

@rustbot modify labels to: +S-waiting-on-review -S-waiting-on-author

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2020
@Dylan-DPC-zz

Copy link
Copy Markdown

r? @Dylan-DPC

@bors r+ rollup

@bors

bors commented Jul 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 049f6ea has been approved by Dylan-DPC

@Dylan-DPC-zz

Copy link
Copy Markdown

r? @Dylan-DPC

@bors r+ rollup

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020
@bors

bors commented Jul 9, 2020

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: Update cargo #74137

@bors

bors commented Jul 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 049f6ea has been approved by Dylan-DPC

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 9, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 9, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#73292 (Fixing broken link for the Eq trait)
- rust-lang#73791 (Allow for parentheses after macro intra-doc-links)
- rust-lang#74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.)
- rust-lang#74077 (Use relative path for local links to primitives)
- rust-lang#74079 (Eliminate confusing "globals" terminology.)
- rust-lang#74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.)
- rust-lang#74136 (Fix broken link in rustdocdoc)
- rust-lang#74137 (Update cargo)
- rust-lang#74142 (Liballoc use vec instead of vector)
- rust-lang#74143 (Try remove unneeded ToString import in liballoc slice)
- rust-lang#74146 (update miri)
- rust-lang#74150 (Avoid "blacklist")
- rust-lang#74184 (Add docs for intra-doc-links)
- rust-lang#74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity)
Failed merges:
- rust-lang#74122 (Start-up clean-up)
- rust-lang#74127 (Avoid "whitelist")
r? @ghost
@bors
bors merged commit 5fc46fa into rust-lang:masterJul 10, 2020
@poliorcetics
poliorcetics deleted the fix-link-in-partialeq branch July 10, 2020 07:01
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in PartialEq documentation

10 participants

@poliorcetics@rust-highfive@JohnCSimon@Muirrum@Dylan-DPC-zz@bors@GuillaumeGomez@cuviper@withoutboats@rustbot