Skip to content

Document the mut keyword - #73621

Merged
bors merged 2 commits into
rust-lang:masterfrom
poliorcetics:mut-keyword
Jun 26, 2020
Merged

Document the mut keyword#73621
bors merged 2 commits into
rust-lang:masterfrom
poliorcetics:mut-keyword

Conversation

@poliorcetics

@poliorceticspoliorcetics commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

Partial fix for #34601.

Documentation for the mut keyword. I think it's okay for it to be quite short, this is not the book not the reference, but if you find something is missing, do not hesitate to tell me.

@rust-highfive

rust-highfive commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2020
@poliorceticspoliorcetics mentioned this pull request Jun 22, 2020
Closed
@poliorcetics

poliorcetics commented Jun 22, 2020

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: T-doc,C-enhancement

@rustbotrustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 22, 2020
lcnr
lcnr reviewed Jun 22, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
lcnr
lcnr reviewed Jun 22, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
lcnr
lcnr reviewed Jun 22, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
lcnr
lcnr reviewed Jun 22, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
lcnr
lcnr reviewed Jun 22, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
@sfackler

sfackler commented Jun 22, 2020

Copy link
Copy Markdown
Member

r? @rust-lang/docs

@Dylan-DPC-zz

Dylan-DPC-zz commented Jun 23, 2020

Copy link
Copy Markdown

r? @steveklabnik

Dylan-DPC-zz
Dylan-DPC-zz reviewed Jun 23, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
steveklabnik
steveklabnik suggested changes Jun 23, 2020
View reviewed changes

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny changes, but looks good to me overall, thanks!

Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
steveklabnik
steveklabnik suggested changes Jun 25, 2020
View reviewed changes

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry! just a few more tiny things.

r=me after they're added.

Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
@steveklabnik

steveklabnik commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thank you!

@bors

bors commented Jun 25, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 3d09017 has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 25, 2020
@Dylan-DPC
Rollup merge ofrust-lang#73621- poliorcetics:mut-keyword, r=stevekl…
9a5c4d7
…abnik
Document the mut keyword
Partial fix for rust-lang#34601.
Documentation for the `mut` keyword. I think it's okay for it to be quite short, this is not the book not the reference, but if you find something is missing, do not hesitate to tell me.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 25, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 26, 2020
@Manishearth
Rollup merge ofrust-lang#73621- poliorcetics:mut-keyword, r=stevekl…
2334b93
…abnik
Document the mut keyword
Partial fix for rust-lang#34601.
Documentation for the `mut` keyword. I think it's okay for it to be quite short, this is not the book not the reference, but if you find something is missing, do not hesitate to tell me.
@ManishearthManishearth mentioned this pull request Jun 26, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 26, 2020
@Manishearth
Rollup merge ofrust-lang#73621- poliorcetics:mut-keyword, r=stevekl…
7f1eb2e
…abnik
Document the mut keyword
Partial fix for rust-lang#34601.
Documentation for the `mut` keyword. I think it's okay for it to be quite short, this is not the book not the reference, but if you find something is missing, do not hesitate to tell me.
This was referenced Jun 26, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 26, 2020
@bors
Auto merge ofrust-lang#73746- Manishearth:rollup-80jnynm, r=Manishe…
e093b65
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#72617 (Add a fast path for `std::thread::panicking`.)
- rust-lang#72738 (Self contained linking option)
- rust-lang#72770 (Implement mixed script confusable lint.)
- rust-lang#73418 (Add unstable `core::mem::variant_count` intrinsic)
- rust-lang#73460 (Emit line info for generator variants)
- rust-lang#73534 (Provide suggestions for some moved value errors)
- rust-lang#73538 (make commented examples use valid syntax, and be more consistent )
- rust-lang#73581 (Create 0766 error code)
- rust-lang#73619 (Document the mod keyword)
- rust-lang#73621 (Document the mut keyword)
- rust-lang#73648 (Document the return keyword)
- rust-lang#73673 (Fix ptr doc warnings.)
- rust-lang#73674 (Tweak binop errors)
- rust-lang#73687 (Clean up E0701 explanation)
Failed merges:
- rust-lang#73708 (Explain move errors that occur due to method calls involving `self` (take two))
r? @ghost
@bors
bors merged commit f91330a into rust-lang:masterJun 26, 2020
@poliorcetics
poliorcetics deleted the mut-keyword branch June 26, 2020 07:42
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments
+2 more reviewers
@Dylan-DPC-zzDylan-DPC-zzDylan-DPC-zz left review comments
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-enhancementCategory: An issue proposing an enhancement or a PR with one.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

9 participants

@poliorcetics@rust-highfive@sfackler@Dylan-DPC-zz@steveklabnik@bors@lcnr@cuviper@rustbot