Explain move errors that occur due to method calls involving `self` (take two) by Aaron1011 · Pull Request #73708 · rust-lang/rust

Aaron1011 · 2020-06-24T22:44:33Z

This is a re-attempt of #72389 (which was reverted in #73594)
Instead of using ExpnKind::Desugaring to represent operators, this PR
checks the lang item directly.

rust-highfive · 2020-06-24T22:44:37Z

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2020-06-25T10:21:17Z

I'd like to investigate the possibility of removing lowering-time expansions entirely in some observable future, but in the meantime this looks ok.

(I didn't look at the rustc_mir parts.)

petrochenkov · 2020-06-25T10:21:37Z

r? @davidtwco

davidtwco

LGTM, one question about the new diagnostic output but otherwise great.

bors · 2020-06-25T13:00:14Z

☔ The latest upstream changes (presumably #72559) made this pull request unmergeable. Please resolve the merge conflicts.

Aaron1011 · 2020-06-25T20:00:36Z

@davidtwco: This should now be ready to merge

davidtwco · 2020-06-25T21:44:28Z

@bors r+

bors · 2020-06-25T21:44:30Z

📌 Commit fbf1cd7790fb55de65b9d36f5cb3feadfa385046 has been approved by davidtwco

@ghost

…arth Rollup of 14 pull requests Successful merges: - rust-lang#72617 (Add a fast path for `std::thread::panicking`.) - rust-lang#72738 (Self contained linking option) - rust-lang#72770 (Implement mixed script confusable lint.) - rust-lang#73418 (Add unstable `core::mem::variant_count` intrinsic) - rust-lang#73460 (Emit line info for generator variants) - rust-lang#73534 (Provide suggestions for some moved value errors) - rust-lang#73538 (make commented examples use valid syntax, and be more consistent ) - rust-lang#73581 (Create 0766 error code) - rust-lang#73619 (Document the mod keyword) - rust-lang#73621 (Document the mut keyword) - rust-lang#73648 (Document the return keyword) - rust-lang#73673 (Fix ptr doc warnings.) - rust-lang#73674 (Tweak binop errors) - rust-lang#73687 (Clean up E0701 explanation) Failed merges: - rust-lang#73708 (Explain move errors that occur due to method calls involving `self` (take two)) r? @ghost

bors · 2020-06-26T06:31:30Z

☔ The latest upstream changes (presumably #73746) made this pull request unmergeable. Please resolve the merge conflicts.

Also, implement this query for the local crate, not just foreign crates.

Aaron1011 · 2020-06-26T20:12:12Z

@davidtwco:I've rebased against master, and applied @jyn514's suggestion

This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594) Instead of using `ExpnKind::Desugaring` to represent operators, this PR checks the lang item directly.

davidtwco · 2020-06-27T13:23:19Z

@bors r+

bors · 2020-06-27T13:23:20Z

📌 Commit fa6a61c has been approved by davidtwco

@ghost

…arth Rollup of 10 pull requests Successful merges: - rust-lang#72796 (MIR sanity check: validate types on assignment) - rust-lang#73243 (Add documentation to point to `File::open` or `OpenOptions::open` instead of `is_file` to check read/write possibility) - rust-lang#73525 (Prepare for LLVM 11) - rust-lang#73672 (Adds a clearer message for when the async keyword is missing from a f…) - rust-lang#73708 (Explain move errors that occur due to method calls involving `self` (take two)) - rust-lang#73758 (improper_ctypes: fix remaining `Reveal:All`) - rust-lang#73763 (errors: use `-Z terminal-width` in JSON emitter) - rust-lang#73796 (replace more `DefId`s with `LocalDefId`) - rust-lang#73797 (fix typo in self-profile.md) - rust-lang#73809 (Add links to fs::DirEntry::metadata) Failed merges: r? @ghost

PR rust-lang#73708 added a more detailed explanation of move errors that occur due to a call to a method that takes `self`. This PR extends that logic to work when a move error occurs due to a method call in the previous iteration of a loop.

Explain method-call move errors in loops PR rust-lang#73708 added a more detailed explanation of move errors that occur due to a call to a method that takes `self`. This PR extends that logic to work when a move error occurs due to a method call in the previous iteration of a loop.

rust-highfive assigned davidtwco Jun 24, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2020

Aaron1011 changed the title ~~Explain move errors that occur due to method calls involving `self (take two)~~Explain move errors that occur due to method calls involving self (take two)Jun 24, 2020

petrochenkov self-assigned this Jun 25, 2020

davidtwco removed their assignment Jun 25, 2020

petrochenkov reviewed Jun 25, 2020
View reviewed changes

Comment threadsrc/librustc_span/lib.rs Outdated

rust-highfive assigned davidtwco and unassigned petrochenkov Jun 25, 2020

davidtwco approved these changes Jun 25, 2020
View reviewed changes

Comment threadsrc/test/ui/binop/binop-consume-args.stderr

Aaron1011 force-pushed the feature/reland-move-fn-self-msg branch from cf4c2db to fbf1cd7Compare June 25, 2020 20:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2020

This was referenced Jun 26, 2020
Rollup of 14 pull requests #73744
Closed
Rollup of 15 pull requests #73745
Closed
Rollup of 14 pull requests #73746
Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2020

jyn514 reviewed Jun 26, 2020
View reviewed changes

Comment threadsrc/librustc_hir/lang_items.rs Outdated

Make fn_arg_names return Ident instead of symbol
36ac08e
Also, implement this query for the local crate, not just foreign crates.

Aaron1011 force-pushed the feature/reland-move-fn-self-msg branch from fbf1cd7 to d412181Compare June 26, 2020 20:10

Explain move errors that occur due to method calls involving self
fa6a61c
This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594) Instead of using `ExpnKind::Desugaring` to represent operators, this PR checks the lang item directly.

Aaron1011 force-pushed the feature/reland-move-fn-self-msg branch from d412181 to fa6a61cCompare June 26, 2020 20:28

Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2020

Manishearth mentioned this pull request Jun 28, 2020
Rollup of 10 pull requests #73830
Merged

bors merged commit b236e49 into rust-lang:masterJun 28, 2020

Aaron1011 mentioned this pull request Dec 23, 2020
Explain method-call move errors in loops #80324
Merged

cuviper added this to the 1.46 milestone May 2, 2024

Uh oh!

Uh oh!

Conversation

Aaron1011 commented Jun 24, 2020

Uh oh!

rust-highfive commented Jun 24, 2020

Uh oh!

Uh oh!

petrochenkov commented Jun 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Jun 25, 2020

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bors commented Jun 25, 2020

Uh oh!

Aaron1011 commented Jun 25, 2020

Uh oh!

davidtwco commented Jun 25, 2020

Uh oh!

bors commented Jun 25, 2020

Uh oh!

bors commented Jun 26, 2020

Uh oh!

Uh oh!

Aaron1011 commented Jun 26, 2020

Uh oh!

davidtwco commented Jun 27, 2020

Uh oh!

bors commented Jun 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

petrochenkov commented Jun 25, 2020•
edited
Loading