Skip to content

variant_count: avoid incorrect dummy implementation - #74064

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:variant-count-bootstrap
Jul 6, 2020
Merged

variant_count: avoid incorrect dummy implementation#74064
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:variant-count-bootstrap

Conversation

@RalfJung

Copy link
Copy Markdown
Member

This also avoids a stage 0 doctest failure.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2020
@RalfJung

Copy link
Copy Markdown
MemberAuthor

Cc @DoctorN
r? @kennytm

@rust-highfiverust-highfive assigned kennytm and unassigned cramertjJul 5, 2020
@cofibrant

Copy link
Copy Markdown
Contributor

Thanks!

@kennytm

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 9cb1ffd has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2020
…arth
Rollup of 12 pull requests
Successful merges:
- rust-lang#72688 (added .collect() into String from Box<str>)
- rust-lang#73787 (Add unstable docs for rustc_attrs)
- rust-lang#73834 (Some refactoring around intrinsic type checking)
- rust-lang#73871 (Fix try_print_visible_def_path for Rust 2018)
- rust-lang#73937 (Explain exhaustive matching on {usize,isize} maximum values)
- rust-lang#73973 (Use `Span`s to identify unreachable subpatterns in or-patterns)
- rust-lang#74000 (add `lazy_normalization_consts` feature gate)
- rust-lang#74025 (Remove unnecessary release from Arc::try_unwrap)
- rust-lang#74027 (Convert more `DefId`s to `LocalDefId`s)
- rust-lang#74055 (Fix spacing in Iterator fold doc)
- rust-lang#74057 (expected_found `&T` -> `T`)
- rust-lang#74064 (variant_count: avoid incorrect dummy implementation)
Failed merges:
r? @ghost
@bors
bors merged commit e624363 into rust-lang:masterJul 6, 2020
@RalfJung
RalfJung deleted the variant-count-bootstrap branch July 7, 2020 07:12
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@RalfJung@rust-highfive@cofibrant@kennytm@bors@cuviper@cramertj