Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #74073
Merged
Merged
Conversation
Co-authored-by: Ralf Jung <post@ralfj.de>
The recursive check of `try_print_visible_def_path` did not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self). This fixes issue rust-lang#56175.
The thread that recovers the unique access to Arc inner value (e.g., drop when ref-count strong reaches zero, successful try_unwrap), ensures that other operations on Arc inner value happened before by synchronizing with release operations performed when decrementing the reference counter. When try_unwrap succeeds, the current thread recovers the unique access to Arc inner value, so release is unnecessary.
added .collect() into String from Box<str> I have not created an rfc, because i felt like this is a very minor change. i have just set a random feature name and rust version as stability attribute, i expect to have to change that, i just don't know what the policy on that is. all guides i could find focused on contributing to the compiler, not contributing to the standard library. drawbacks: more code in the standard library, could be replaced with specialization: base-implementation for AsRef\<str> and specialization for String and Cow. i can write that code if ppl want it. advantages: using "real strings" i.e. Box\<str> is as ergonomic as string slices (&str) and string buffers (String) with iterators.
Add unstable docs for rustc_attrs r? @RalfJung
…-morse Some refactoring around intrinsic type checking So... This PR went a bit overboard. I wanted to make the `rustc_peek` intrinsic safe (cc @ecstatic-morse ), and remembered a long-standing itch of mine. So I made that huge `&str` match for the intrinsic name a match on `Symbol`s (so basically `u32`s). This is unlikely to have a positive perf effect, even if it likely has better codegen (intrinsics are used rarely, mostly once in their wrapper), so it's mostly a consistency thing since other places actually match on the symbol name of the intrinsics.
…r=petrochenkov Fix try_print_visible_def_path for Rust 2018 The recursive check of `try_print_visible_def_path` did not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self). This fixesrust-lang#56175.
…, r=varkor
Explain exhaustive matching on {usize,isize} maximum values
The wording is taken from https://github.com/rust-lang/rfcs/blob/master/text/2591-exhaustive-integer-pattern-matching.md#reference-level-explanation.
Fixesrust-lang#73919
r? @varkorUse `Span`s to identify unreachable subpatterns in or-patterns Fixesrust-lang#71977
…arkor add `lazy_normalization_consts` feature gate In rust-lang#71973 I underestimated the amount of code which is influenced by lazy normalization of consts and decided against having a separate feature flag for this. Looking a bit more into this, the following issues are already working with lazy norm in its current state rust-lang#47814rust-lang#57739rust-lang#73980 I therefore think it is worth it to enable lazy norm separately. Note that `#![feature(const_generics)]` still automatically activates this feature, so using `#![feature(const_generics, lazy_normalization_consts)]` is redundant. r? @varkor@nikomatsakis
Remove unnecessary release from Arc::try_unwrap The thread that recovers the unique access to Arc inner value (e.g., drop when ref-count strong reaches zero, successful try_unwrap), ensures that other operations on Arc inner value happened before by synchronizing with release operations performed when decrementing the reference counter. When try_unwrap succeeds, the current thread recovers the unique access to Arc inner value, so release is unnecessary. r? @Amanieu
Convert more `DefId`s to `LocalDefId`s
Fix spacing in Iterator fold doc
expected_found `&T` -> `T`
…=kennytm variant_count: avoid incorrect dummy implementation This also avoids a stage 0 doctest failure.
Manishearth
commented
Jul 5, 2020
MemberAuthor
bors
commented
Jul 5, 2020
Collaborator
📌 Commit e624363 has been approved by |
bors
commented
Jul 5, 2020
Collaborator
bors
commented
Jul 6, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Jul 6, 2020
rust-highfive
commented
Jul 6, 2020
Contributor
📣 Toolstate changed by #74073! Tested on commit 0c03aee. 💔 rls on windows: test-pass → build-fail (cc @Xanewok). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 6, 2020
Tested on commit rust-lang/rust@0c03aee. Direct link to PR: <rust-lang/rust#74073> 💔 rls on windows: test-pass → build-fail (cc @Xanewok). 💔 rls on linux: test-pass → build-fail (cc @Xanewok). 💔 rustfmt on windows: test-pass → build-fail (cc @topecongiro). 💔 rustfmt on linux: test-pass → build-fail (cc @topecongiro).
Manishearth
commented
Jul 6, 2020
MemberAuthor
Potential tool failure: This might be #74027 |
nnethercote
commented
Jul 7, 2020
Contributor
This caused a slight perf regression on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Spans to identify unreachable subpatterns in or-patterns #73973 (UseSpans to identify unreachable subpatterns in or-patterns)lazy_normalization_constsfeature gate #74000 (addlazy_normalization_constsfeature gate)DefIds toLocalDefIds #74027 (Convert moreDefIds toLocalDefIds)&T->T#74057 (expected_found&T->T)Failed merges:
r? @ghost