Skip to content

Add rust-analyzer to the build manifest - #74089

Merged
bors merged 1 commit into
rust-lang:masterfrom
matklad:ship-rust-analyzer-some-more
Jul 7, 2020
Merged

Add rust-analyzer to the build manifest#74089
bors merged 1 commit into
rust-lang:masterfrom
matklad:ship-rust-analyzer-some-more

Conversation

@matklad

Copy link
Copy Markdown
Contributor

Does not die locally, produces rust-analyzer-0.1.0-dev-x86_64-unknown-linux-gnu.tar.gz.sha256 and add something about rust-analyzer to some .toml file. Seems like a success?

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2020
@matklad

Copy link
Copy Markdown
ContributorAuthor

r? @pietroalbini

Comment threadsrc/tools/build-manifest/src/main.rs Outdated
@matklad
matkladforce-pushed the ship-rust-analyzer-some-more branch 2 times, most recently from 55ff0ac to 98530dfCompareJuly 6, 2020 08:46
Comment threadsrc/tools/build-manifest/src/main.rs Outdated
@matklad
matkladforce-pushed the ship-rust-analyzer-some-more branch from 98530df to 2400582CompareJuly 6, 2020 08:49
Comment threadsrc/tools/build-manifest/src/main.rs Outdated
@matklad
matkladforce-pushed the ship-rust-analyzer-some-more branch from 2400582 to dcf9551CompareJuly 6, 2020 08:55
@emilyalbini

Copy link
Copy Markdown
Member

I'm so happy to approve this. Thanks for all the hard work on rust-analyzer ❤️

@bors r+

@bors

bors commented Jul 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit dcf95510a553a50a79174e93ada37a536cbb8bd2 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2020
@emilyalbini

Copy link
Copy Markdown
Member

@bors r-

Needs ./x.py fmt.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2020
@matklad
matkladforce-pushed the ship-rust-analyzer-some-more branch from dcf9551 to fdd39a3CompareJuly 6, 2020 09:13
@emilyalbini

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit fdd39a3 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 6, 2020
…e, r=pietroalbini
Add rust-analyzer to the build manifest
Does not die locally, produces `rust-analyzer-0.1.0-dev-x86_64-unknown-linux-gnu.tar.gz.sha256` and add something about rust-analyzer to some `.toml` file. Seems like a success?
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 6, 2020
…e, r=pietroalbini
Add rust-analyzer to the build manifest
Does not die locally, produces `rust-analyzer-0.1.0-dev-x86_64-unknown-linux-gnu.tar.gz.sha256` and add something about rust-analyzer to some `.toml` file. Seems like a success?
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#70563 ([rustdoc] Page hash handling)
- rust-lang#73856 (Edit librustc_lexer top-level docs)
- rust-lang#73870 (typeck: adding type information to projection)
- rust-lang#73953 (Audit hidden/short code suggestions)
- rust-lang#73962 (libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)])
- rust-lang#73969 (mir: mark mir construction temporaries as internal)
- rust-lang#73974 (Move A|Rc::as_ptr from feature(weak_into_raw) to feature(rc_as_ptr))
- rust-lang#74067 (rustdoc: Restore underline text decoration on hover for FQN in header)
- rust-lang#74074 (Fix the return type of Windows' `OpenOptionsExt::security_qos_flags`.)
- rust-lang#74078 (Always resolve type@primitive as a primitive, not a module)
- rust-lang#74089 (Add rust-analyzer to the build manifest)
- rust-lang#74090 (Remove unused RUSTC_DEBUG_ASSERTIONS)
- rust-lang#74102 (Fix const prop ICE)
- rust-lang#74112 (Expand abbreviation in core::ffi description)
Failed merges:
r? @ghost
@bors
bors merged commit caa858b into rust-lang:masterJul 7, 2020
@matklad
matklad deleted the ship-rust-analyzer-some-more branch July 7, 2020 16:34
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#70563 ([rustdoc] Page hash handling)
- rust-lang#73856 (Edit librustc_lexer top-level docs)
- rust-lang#73870 (typeck: adding type information to projection)
- rust-lang#73953 (Audit hidden/short code suggestions)
- rust-lang#73962 (libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)])
- rust-lang#73969 (mir: mark mir construction temporaries as internal)
- rust-lang#73974 (Move A|Rc::as_ptr from feature(weak_into_raw) to feature(rc_as_ptr))
- rust-lang#74067 (rustdoc: Restore underline text decoration on hover for FQN in header)
- rust-lang#74074 (Fix the return type of Windows' `OpenOptionsExt::security_qos_flags`.)
- rust-lang#74078 (Always resolve type@primitive as a primitive, not a module)
- rust-lang#74089 (Add rust-analyzer to the build manifest)
- rust-lang#74090 (Remove unused RUSTC_DEBUG_ASSERTIONS)
- rust-lang#74102 (Fix const prop ICE)
- rust-lang#74112 (Expand abbreviation in core::ffi description)
Failed merges:
r? @ghost
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@matklad@rust-highfive@emilyalbini@bors@kinnison@cuviper@nikomatsakis