Skip to content

Remove unused RUSTC_DEBUG_ASSERTIONS - #74090

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:rustc-debug-assertions
Jul 7, 2020
Merged

Remove unused RUSTC_DEBUG_ASSERTIONS#74090
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:rustc-debug-assertions

Conversation

@tmiasko

Copy link
Copy Markdown
Contributor

Since #73374 the rustc wrapper no longer configures debug assertions
based on RUSTC_DEBUG_ASSERTIONS environment variable.

r? @RalfJung

Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
based on RUSTC_DEBUG_ASSERTIONS environment variable.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2020
@RalfJung

Copy link
Copy Markdown
Member

Less hacky work-arounds, great, thanks. :)
@bors r+ rollup

@bors

bors commented Jul 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5fa19ad has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 6, 2020
…alfJung
Remove unused RUSTC_DEBUG_ASSERTIONS
Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
based on RUSTC_DEBUG_ASSERTIONS environment variable.
r? @RalfJung
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 6, 2020
…alfJung
Remove unused RUSTC_DEBUG_ASSERTIONS
Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
based on RUSTC_DEBUG_ASSERTIONS environment variable.
r? @RalfJung
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jul 6, 2020
…alfJung
Remove unused RUSTC_DEBUG_ASSERTIONS
Since rust-lang#73374 the rustc wrapper no longer configures debug assertions
based on RUSTC_DEBUG_ASSERTIONS environment variable.
r? @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#70563 ([rustdoc] Page hash handling)
- rust-lang#73856 (Edit librustc_lexer top-level docs)
- rust-lang#73870 (typeck: adding type information to projection)
- rust-lang#73953 (Audit hidden/short code suggestions)
- rust-lang#73962 (libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)])
- rust-lang#73969 (mir: mark mir construction temporaries as internal)
- rust-lang#73974 (Move A|Rc::as_ptr from feature(weak_into_raw) to feature(rc_as_ptr))
- rust-lang#74067 (rustdoc: Restore underline text decoration on hover for FQN in header)
- rust-lang#74074 (Fix the return type of Windows' `OpenOptionsExt::security_qos_flags`.)
- rust-lang#74078 (Always resolve type@primitive as a primitive, not a module)
- rust-lang#74089 (Add rust-analyzer to the build manifest)
- rust-lang#74090 (Remove unused RUSTC_DEBUG_ASSERTIONS)
- rust-lang#74102 (Fix const prop ICE)
- rust-lang#74112 (Expand abbreviation in core::ffi description)
Failed merges:
r? @ghost
@bors
bors merged commit 50e22bd into rust-lang:masterJul 7, 2020
@tmiasko
tmiasko deleted the rustc-debug-assertions branch July 7, 2020 05:19
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#70563 ([rustdoc] Page hash handling)
- rust-lang#73856 (Edit librustc_lexer top-level docs)
- rust-lang#73870 (typeck: adding type information to projection)
- rust-lang#73953 (Audit hidden/short code suggestions)
- rust-lang#73962 (libstd/net/tcp.rs: #![deny(unsafe_op_in_unsafe_fn)])
- rust-lang#73969 (mir: mark mir construction temporaries as internal)
- rust-lang#73974 (Move A|Rc::as_ptr from feature(weak_into_raw) to feature(rc_as_ptr))
- rust-lang#74067 (rustdoc: Restore underline text decoration on hover for FQN in header)
- rust-lang#74074 (Fix the return type of Windows' `OpenOptionsExt::security_qos_flags`.)
- rust-lang#74078 (Always resolve type@primitive as a primitive, not a module)
- rust-lang#74089 (Add rust-analyzer to the build manifest)
- rust-lang#74090 (Remove unused RUSTC_DEBUG_ASSERTIONS)
- rust-lang#74102 (Fix const prop ICE)
- rust-lang#74112 (Expand abbreviation in core::ffi description)
Failed merges:
r? @ghost
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tmiasko@RalfJung@bors@cuviper@rust-highfive