Skip to content

Handle case of incomplete local ty more gracefully - #74337

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:ty-parse-recovery
Jul 16, 2020
Merged

Handle case of incomplete local ty more gracefully#74337
bors merged 1 commit into
rust-lang:masterfrom
estebank:ty-parse-recovery

Conversation

@estebank

Copy link
Copy Markdown
Contributor

When encountering a local binding with a type that isn't completed, the
parser will reach a = token. When this happen, consider the type
"complete" as far as the parser is concerned to avoid further errors
being emitted by parse recovery logic.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2020
@estebank

Copy link
Copy Markdown
ContributorAuthor

r? @varkor

@rust-highfiverust-highfive assigned varkor and unassigned eddybJul 14, 2020
@bors

This comment has been minimized.

When encountering a local binding with a type that isn't completed, the
parser will reach a `=` token. When this happen, consider the type
"complete" as far as the parser is concerned to avoid further errors
being emitted by parse recovery logic.
@varkor

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit ce3bd29 has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2020
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#72973 (RISC-V GNU/Linux as host platform)
- rust-lang#73918 (Clean up E0715 explanation)
- rust-lang#73959 (Clean up E0716 explanation)
- rust-lang#74119 (Remove `Compiler::compile()`.)
- rust-lang#74196 (Add option to collapse automatically implementors)
- rust-lang#74218 (Add margin after doc search results)
- rust-lang#74276 (improve DiscriminantKind handling)
- rust-lang#74291 (Added docs for `From<c_int>` for `ExitStatus`)
- rust-lang#74294 (Update cross-compilation README)
- rust-lang#74337 (Handle case of incomplete local ty more gracefully)
- rust-lang#74344 (Remove string comparison and use diagnostic item instead)
- rust-lang#74347 (Initialize default providers only once)
- rust-lang#74353 (Edit docs for rustc_middle::dep_graph::dep_node)
- rust-lang#74374 (Add a 1.45 release note on lto vs. embed-bitcode)
Failed merges:
- rust-lang#74251 (Teach bootstrap about target files vs target triples)
r? @ghost
@bors
bors merged commit f4bbd0e into rust-lang:masterJul 16, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank@rust-highfive@bors@varkor@cuviper@eddyb