Skip to content

Initialize default providers only once - #74347

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:ive-got-a-small-query-for-you
Jul 16, 2020
Merged

Initialize default providers only once#74347
bors merged 1 commit into
rust-lang:masterfrom
jyn514:ive-got-a-small-query-for-you

Conversation

@jyn514

@jyn514jyn514 commented Jul 15, 2020

Copy link
Copy Markdown
Member

This avoids copying a new Providers struct for each downstream crate
that wants to use it.

Follow-up to #74283 without the perf hit.

r? @eddyb

@jyn514jyn514 mentioned this pull request Jul 15, 2020
Closed
@eddyb

eddyb commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

LGTM, let's make sure this is a perf noop:
@bors try @rust-timer queue

@rust-timer

rust-timer commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 with merge cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9...

@eddybeddyb mentioned this pull request Jul 15, 2020
Merged
@bors

bors commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9 (cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9)

@rust-timer

rust-timer commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

Queued cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9 with parent 23744c8, future comparison URL.

@rust-timer

rust-timer commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit (cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9): comparison url.

@jyn514

jyn514 commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

No change in instructions, wall time is all over the place but looking at the last noise run that might be normal?

@eddyb

eddyb commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

Yeah you can generally ignore wall-time. The important thing to look at here is helloworld-check, which had no changes.

@bors r+

@bors

bors commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 has been approved by eddyb

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 15, 2020
@jyn514

jyn514 commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

@eddyb I'm going to rebase #73566 over this and merge them both at once so we don't have to wait for bors twice.

@jyn514
Initialize default providers only once
f6764c4
This avoids copying a new `Providers` struct for each downstream crate
that wants to use it.
@jyn514
jyn514force-pushed the ive-got-a-small-query-for-you branch from 7798fe1 to f6764c4CompareJuly 15, 2020 14:53
@Manishearth

Manishearth commented Jul 15, 2020

Copy link
Copy Markdown
Member

@bors r=eddyb

still queueing this in case it gets rolled up

@bors

bors commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f6764c4 has been approved by eddyb

This was referenced Jul 15, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2020
@bors
Auto merge ofrust-lang#74375- Manishearth:rollup-10vbpdh, r=Manishe…
e2e29de
…arth
Rollup of 14 pull requests
Successful merges:
- rust-lang#72973 (RISC-V GNU/Linux as host platform)
- rust-lang#73918 (Clean up E0715 explanation)
- rust-lang#73959 (Clean up E0716 explanation)
- rust-lang#74119 (Remove `Compiler::compile()`.)
- rust-lang#74196 (Add option to collapse automatically implementors)
- rust-lang#74218 (Add margin after doc search results)
- rust-lang#74276 (improve DiscriminantKind handling)
- rust-lang#74291 (Added docs for `From<c_int>` for `ExitStatus`)
- rust-lang#74294 (Update cross-compilation README)
- rust-lang#74337 (Handle case of incomplete local ty more gracefully)
- rust-lang#74344 (Remove string comparison and use diagnostic item instead)
- rust-lang#74347 (Initialize default providers only once)
- rust-lang#74353 (Edit docs for rustc_middle::dep_graph::dep_node)
- rust-lang#74374 (Add a 1.45 release note on lto vs. embed-bitcode)
Failed merges:
- rust-lang#74251 (Teach bootstrap about target files vs target triples)
r? @ghost
@bors
bors merged commit dceafac into rust-lang:masterJul 16, 2020
@jyn514
jyn514 deleted the ive-got-a-small-query-for-you branch July 16, 2020 11:27
@jyn514jyn514 mentioned this pull request Jul 10, 2021
Closed
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514@eddyb@rust-timer@bors@Manishearth@cuviper