Uh oh!
There was an error while loading. Please reload this page.
Use LocalDefId instead of HirId for reachable_set elements. - #74346
Merged
Conversation
eddyb
commented
Jul 14, 2020
ContributorAuthor
@bors try @rust-timer queue |
rust-timer
commented
Jul 14, 2020
Collaborator
Awaiting bors try build completion |
bors
commented
Jul 14, 2020
Collaborator
⌛ Trying commit 6716c0e4207bfb5e4fa845e097d2c288bc98277e with merge 902ba0f9165e2d3491f89552b03ad7ba8d26e9a8... |
bors
commented
Jul 15, 2020
Collaborator
☀️ Try build successful - checks-actions, checks-azure |
rust-timer
commented
Jul 15, 2020
Collaborator
Queued 902ba0f9165e2d3491f89552b03ad7ba8d26e9a8 with parent 23744c8, future comparison URL. |
rust-timer
commented
Jul 15, 2020
Collaborator
Finished benchmarking try commit (902ba0f9165e2d3491f89552b03ad7ba8d26e9a8): comparison url. |
eddyb
commented
Jul 15, 2020
ContributorAuthor
Mostly neutral, so this is more of a cleanup PR than an optimization one. |
eddyb
commented
Jul 21, 2020
ContributorAuthor
Somehow this ended up without an assignee? |
nikomatsakis
approved these changes
Jul 21, 2020
nikomatsakis
commented
Jul 21, 2020
Contributor
r=me but needs rebase |
eddyb
commented
Aug 16, 2020
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Aug 16, 2020
Collaborator
📌 Commit 8b86b28 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Aug 16, 2020
Use LocalDefId instead of HirId for reachable_set elements. The only `HirId`s being tracked there that don't have matching `DefId`s are local variables, and that's an accident from rust-lang#44316 (where I preserved the old behavior, even if nothing relied on reachability tracking local variables).
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#74204 (Don't visit foreign function bodies when lowering ast to hir) - rust-lang#74314 (rustc_typeck: construct {Closure,Generator}Substs more directly.) - rust-lang#74346 (Use LocalDefId instead of HirId for reachable_set elements.) - rust-lang#74399 (Move DelaySpanBugEmitted to ty::context) - rust-lang#75177 (Add regression test for issue-66768) - rust-lang#75223 (Add #[track_caller] to `Session::delay_span_bug`) - rust-lang#75423 (Move to intra-doc links for /library/core/src/hint.rs) - rust-lang#75485 (pin docs: add some forward references) - rust-lang#75569 (Bump minor version of emsdk to 1.38.47) - rust-lang#75596 (Switch to intra-doc links in /sys/windows/ext/{ffi,fs,process}.rs) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only
HirIds being tracked there that don't have matchingDefIds are local variables, and that's an accident from #44316 (where I preserved the old behavior, even if nothing relied on reachability tracking local variables).