Skip to content

Bump minor version of emsdk to 1.38.47 - #75569

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:emscripten
Aug 16, 2020
Merged

Bump minor version of emsdk to 1.38.47#75569
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:emscripten

Conversation

@tmiasko

@tmiaskotmiasko commented Aug 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Release Notes:

v1.38.47: 10/02/2019
--------------------
- Add support for FETCH API in WASM backend. This doesn't support FETCH in the
main thread (`USE_FETCH_WORKER=0` is enforced). #9490
- Redefine errno values to be consistent with wasi. This will let us avoid
needing to convert the values back and forth as we use more wasi APIs.
This is an ABI change, which should not be noticeable from user code
unless you use errno defines (like EAGAIN) *and* keep around binaries
compiled with an older version that you link against. In that case, you
should rebuild them. See #9545.
- Removed build option `-s ONLY_MY_CODE` as we now have much better solutions
for that, like building to a wasm object file or using `STANDALONE_WASM`
etc. (see
https://github.com/emscripten-core/emscripten/wiki/WebAssembly-Standalone).
- Emscripten now supports the config file (.emscripten) being placed in the
emscripten directory rather that the current user's home directory.
See #9543

Motivated by changes to errno values which are currently out of sync with those
in libc crate which uses wasi values already. Helps with #72808 and #75532.

@rust-highfive

rust-highfive commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2020
@tmiasko
Bump minor version of emsdk to 1.38.47
8de63eb
Release Notes:
```
v1.38.47: 10/02/2019
--------------------
- Add support for FETCH API in WASM backend. This doesn't support FETCH in the
main thread (`USE_FETCH_WORKER=0` is enforced). rust-lang#9490
- Redefine errno values to be consistent with wasi. This will let us avoid
needing to convert the values back and forth as we use more wasi APIs.
This is an ABI change, which should not be noticeable from user code
unless you use errno defines (like EAGAIN) *and* keep around binaries
compiled with an older version that you link against. In that case, you
should rebuild them. See rust-lang#9545.
- Removed build option `-s ONLY_MY_CODE` as we now have much better solutions
for that, like building to a wasm object file or using `STANDALONE_WASM`
etc. (see
https://github.com/emscripten-core/emscripten/wiki/WebAssembly-Standalone).
- Emscripten now supports the config file (.emscripten) being placed in the
emscripten directory rather that the current user's home directory.
See rust-lang#9543
```
@tmiasko
tmiaskoforce-pushed the emscripten branch 2 times, most recently from 8e254dd to 8de63ebCompareAugust 15, 2020 21:15
@tmiaskotmiasko changed the title Bump minor version of emsdk to 1.38.48Bump minor version of emsdk to 1.38.47Aug 15, 2020
@tmiasko

tmiasko commented Aug 15, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @tlively

@Dylan-DPC-zz

Dylan-DPC-zz commented Aug 16, 2020

Copy link
Copy Markdown

@bors delegate @tlively

@tlively

tlively commented Aug 16, 2020

Copy link
Copy Markdown
Contributor

@bors r+

Thanks!

@bors

bors commented Aug 16, 2020

Copy link
Copy Markdown
Collaborator

@tlively: 🔑 Insufficient privileges: Not in reviewers

@tlively

tlively commented Aug 16, 2020

Copy link
Copy Markdown
Contributor

Oops! Anyone else feel free to land this.

@Dylan-DPC-zz

Dylan-DPC-zz commented Aug 16, 2020

Copy link
Copy Markdown

@bors r=tlively

@bors

bors commented Aug 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8de63eb has been approved by tlively

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 16, 2020
@Dylan-DPC
Rollup merge ofrust-lang#75569- tmiasko:emscripten, r=tlively
f350f9c
Bump minor version of emsdk to 1.38.47
Release Notes:
```
v1.38.47: 10/02/2019
--------------------
- Add support for FETCH API in WASM backend. This doesn't support FETCH in the
main thread (`USE_FETCH_WORKER=0` is enforced). rust-lang#9490
- Redefine errno values to be consistent with wasi. This will let us avoid
needing to convert the values back and forth as we use more wasi APIs.
This is an ABI change, which should not be noticeable from user code
unless you use errno defines (like EAGAIN) *and* keep around binaries
compiled with an older version that you link against. In that case, you
should rebuild them. See rust-lang#9545.
- Removed build option `-s ONLY_MY_CODE` as we now have much better solutions
for that, like building to a wasm object file or using `STANDALONE_WASM`
etc. (see
https://github.com/emscripten-core/emscripten/wiki/WebAssembly-Standalone).
- Emscripten now supports the config file (.emscripten) being placed in the
emscripten directory rather that the current user's home directory.
See rust-lang#9543
```
Motivated by changes to errno values which are currently out of sync with those
in libc crate which uses wasi values already. Helps with rust-lang#72808 and rust-lang#75532.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Aug 16, 2020
Closed
@tmandrytmandry mentioned this pull request Aug 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2020
@bors
Auto merge ofrust-lang#75609- tmandry:rollup-yrcmgke, r=tmandry
7e6d6e5
Rollup of 10 pull requests
Successful merges:
- rust-lang#74204 (Don't visit foreign function bodies when lowering ast to hir)
- rust-lang#74314 (rustc_typeck: construct {Closure,Generator}Substs more directly.)
- rust-lang#74346 (Use LocalDefId instead of HirId for reachable_set elements.)
- rust-lang#74399 (Move DelaySpanBugEmitted to ty::context)
- rust-lang#75177 (Add regression test for issue-66768)
- rust-lang#75223 (Add #[track_caller] to `Session::delay_span_bug`)
- rust-lang#75423 (Move to intra-doc links for /library/core/src/hint.rs)
- rust-lang#75485 (pin docs: add some forward references)
- rust-lang#75569 (Bump minor version of emsdk to 1.38.47)
- rust-lang#75596 (Switch to intra-doc links in /sys/windows/ext/{ffi,fs,process}.rs)
Failed merges:
r? @ghost
@bors
bors merged commit b32df43 into rust-lang:masterAug 16, 2020
@tmiasko
tmiasko deleted the emscripten branch August 17, 2020 16:07
@tmiaskotmiasko mentioned this pull request Aug 17, 2020
Merged
@cuvipercuviper mentioned this pull request Aug 19, 2020
Merged
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytmkennytm

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tmiasko@rust-highfive@Dylan-DPC-zz@tlively@bors@cuviper@kennytm