Skip to content

Revert "Compare tagged/niche-filling layout and pick the best one" - #74611

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:revert-74069-bad-niche
Jul 23, 2020
Merged

Revert "Compare tagged/niche-filling layout and pick the best one"#74611
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:revert-74069-bad-niche

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Jul 22, 2020

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Jul 22, 2020

Copy link
Copy Markdown
MemberAuthor

We can re-land this PR at a later point if there's a way to recover the perf regression here, but given the pretty large variety of performance regressions over the last week it seems good to eagerly revert this to be better able to evaluate the new version.

@bors rollup=never

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 22, 2020
Closed
@eddyb

eddyb commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Oh wow that's definitely much larger than just computing both layouts was (then again I didn't use black_box so maybe LLVM made it seem cheaper than it really is).

@bors r+

@bors

bors commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

‼️ Invalid head SHA found, retrying: 0000000000000000000000000000000000000000

@bors

bors commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1d68600 has been approved by eddyb

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 22, 2020
Merged
@nnethercote

nnethercote commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

@bors rollup=never

Due to perf effects.

@bors

bors commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d68600 with merge f4c6964303040a7712afce36bfe89c3663a032ae...

@bors

bors commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Jul 22, 2020

Copy link
Copy Markdown
MemberAuthor

@bors retry - error inflating zlib

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020
@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d68600 with merge fcac119...

@bors

bors commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: eddyb
Pushing fcac119 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2020
@bors
bors merged commit fcac119 into rust-lang:masterJul 23, 2020
@ehussehuss mentioned this pull request Jul 23, 2020
Closed
@Mark-Simulacrum
Mark-Simulacrum deleted the revert-74069-bad-niche branch July 23, 2020 23:17
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 24, 2020
Closed
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2020
@bors
Auto merge ofrust-lang#74802- Mark-Simulacrum:reland-74069, r=nneth…
873fc46
…ercote
Reland rust-lang#74069
Investigation in rust-lang#74716 has concluded that this PR is indeed not a regression (and in fact the rollup itself is not either).
This reverts the revert in rust-lang#74611.
r? @nnethercote cc @eddyb
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Mark-Simulacrum@eddyb@bors@nnethercote@cuviper@rust-highfive