Uh oh!
There was an error while loading. Please reload this page.
Reland #74069 - #74802
Conversation
Mark-Simulacrum
commented
Jul 27, 2020
@bors try @rust-timer queue Let's double check just in case that this is indeed performance neutral. |
rust-timer
commented
Jul 27, 2020
Awaiting bors try build completion |
bors
commented
Jul 27, 2020
⌛ Trying commit 144b159 with merge 93a1b4821b7cb7b883a996d4787c3fd60fb4fe47... |
bors
commented
Jul 27, 2020
☀️ Try build successful - checks-actions, checks-azure |
rust-timer
commented
Jul 27, 2020
Queued 93a1b4821b7cb7b883a996d4787c3fd60fb4fe47 with parent c709862, future comparison URL. |
rust-timer
commented
Jul 27, 2020
Finished benchmarking try commit (93a1b4821b7cb7b883a996d4787c3fd60fb4fe47): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
nnethercote
commented
Jul 27, 2020
Perf effects are minimal, if anything a tiny improvement. |
Mark-Simulacrum
commented
Aug 11, 2020
@nnethercote or @eddyb, I think this is good to go, would someone mind r+ing? |
nnethercote
commented
Aug 11, 2020
@bors r+ |
bors
commented
Aug 11, 2020
📌 Commit 144b159 has been approved by |
bors
commented
Aug 11, 2020
bors
commented
Aug 12, 2020
☀️ Test successful - checks-actions, checks-azure |
Investigation in #74716 has concluded that this PR is indeed not a regression (and in fact the rollup itself is not either).
This reverts the revert in #74611.
r? @nnethercote cc @eddyb