Skip to content

Make doctests of Ipv4Addr::from(u32) easier to read - #75175

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:doctest-ipv4-fromu32
Aug 7, 2020
Merged

Make doctests of Ipv4Addr::from(u32) easier to read#75175
bors merged 1 commit into
rust-lang:masterfrom
tesuji:doctest-ipv4-fromu32

Conversation

@tesuji

@tesujitesuji commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

There are many zeroes in 0x0d0c0b0au32 which makes it hard to read.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2020
@tesujitesuji mentioned this pull request Aug 5, 2020
@tesuji
tesujiforce-pushed the doctest-ipv4-fromu32 branch from 4cb5727 to 725d37cCompareAugust 5, 2020 05:31
@tesuji

Copy link
Copy Markdown
ContributorAuthor

It seems that Hanna is busy. r? @cuviper

@cuviper

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 725d37c has been approved by cuviper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2020
@JohnTitorJohnTitor mentioned this pull request Aug 7, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
Rollup of 12 pull requests
Successful merges:
- rust-lang#74888 (compiletest: ignore-endian-big, fixesrust-lang#74829, fixesrust-lang#74885)
- rust-lang#75175 (Make doctests of Ipv4Addr::from(u32) easier to read)
- rust-lang#75179 (Remove unused FromInner impl for Ipv4Addr)
- rust-lang#75181 (Fix typo in `librustc_feature/active.rs`)
- rust-lang#75183 (Label rustfmt toolstate issues with A-rustfmt)
- rust-lang#75188 (Handle fieldless tuple structs in diagnostic code)
- rust-lang#75190 (Clean up E0746 explanation)
- rust-lang#75210 (Change the type of `AssertModuleSource::available_cgus`.)
- rust-lang#75211 (Note about endianness of returned value of {integer}::from_be_bytes and friends)
- rust-lang#75217 (Clean up E0747 explanation)
- rust-lang#75232 (Fix typo "TraitObligatiom" -> "TraitObligation")
- rust-lang#75236 (Fix typo "biset" -> "bitset")
Failed merges:
r? @ghost
@bors
bors merged commit c9c7048 into rust-lang:masterAug 7, 2020
@tesuji
tesuji deleted the doctest-ipv4-fromu32 branch August 7, 2020 10:20
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tesuji@rust-highfive@cuviper@bors@hanna-kruppe