Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #75238
Merged
Merged
Conversation
This makes it easier to filter toolstate issues by the tool involved.
in {integer}::from_be_bytes and friends.It's currently a `BTreeSet<Symbol>`, which is a strange type. The
`BTreeSet` suggests that element order is important, but `Symbol` is a
type whose ordering isn't useful to humans. The ordering of the
collection only manifests in an obscure error message ("no module named
`...`") that doesn't appear in any tests.
This commit changes the `Symbol` to a `String`, which is more
typical.…matsakis compiletest: ignore-endian-big, fixesrust-lang#74829, fixesrust-lang#74885 See discussion on rust-lang#74829 I tested it on a Debian s390x machine, works well.
Make doctests of Ipv4Addr::from(u32) easier to read There are many zeroes in `0x0d0c0b0au32` which makes it hard to read.
…crichton Remove unused FromInner impl for Ipv4Addr The removed is a unused unstable implementation.
Fix typo in `librustc_feature/active.rs`
…komatsakis Label rustfmt toolstate issues with A-rustfmt This makes it easier to filter toolstate issues by the tool involved.
…, r=varkor Handle fieldless tuple structs in diagnostic code Fixesrust-lang#75062
…an-DPC Clean up E0746 explanation r? @Dylan-DPC
…e_cgus, r=ecstatic-morse
Change the type of `AssertModuleSource::available_cgus`.
It's currently a `BTreeSet<Symbol>`, which is a strange type. The
`BTreeSet` suggests that element order is important, but `Symbol` is a
type whose ordering isn't useful to humans. The ordering of the
collection only manifests in an obscure error message ("no module named
`...`") that doesn't appear in any tests.
This commit changes the `Symbol` to a `String`, which is more
typical.Note about endianness of returned value of {integer}::from_be_bytes and friends
[`u32::from_be`](https://doc.rust-lang.org/nightly/src/core/num/mod.rs.html#2883-2892) documents about endianness of returned value.
I was confused by endianness of `from_be_bytes` in rust-lang#75086 .…an-DPC Clean up E0747 explanation r? @Dylan-DPC
Fix typo "TraitObligatiom" -> "TraitObligation"
…as-schievink Fix typo "biset" -> "bitset"
JohnTitor
commented
Aug 7, 2020
MemberAuthor
bors
commented
Aug 7, 2020
Collaborator
📌 Commit 3c131d6 has been approved by |
bors
commented
Aug 7, 2020
Collaborator
bors
commented
Aug 7, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
librustc_feature/active.rs#75181 (Fix typo inlibrustc_feature/active.rs)AssertModuleSource::available_cgus. #75210 (Change the type ofAssertModuleSource::available_cgus.)Failed merges:
r? @ghost