Uh oh!
There was an error while loading. Please reload this page.
Enable PGO tests on Windows-gnu - #75184
Closed
mati865 wants to merge 1 commit into
Closed
Conversation
rust-highfive
commented
Aug 5, 2020
Contributor
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
mati865
commented
Aug 5, 2020
MemberAuthor
@bors rollup=iffy |
bors
commented
Aug 5, 2020
Collaborator
@mati865: 🔑 Insufficient privileges: not in try users |
JohnTitor
commented
Aug 19, 2020
Member
Let's re-assigning as this hasn't got any response for about two weeks, r? @petrochenkov I guess you're familiar with it? |
petrochenkov
commented
Aug 20, 2020
Contributor
If it passes through CI, then it's good. |
bors
commented
Aug 20, 2020
Collaborator
📌 Commit 6ad174d has been approved by |
bors
commented
Aug 21, 2020
Collaborator
⌛ Testing commit 6ad174d with merge e43e4f2b9e6b2e2b312370ed2e64fcb84663389b... |
bors
commented
Aug 21, 2020
Collaborator
💔 Test failed - checks-actions |
petrochenkov
commented
Aug 21, 2020
Contributor
|
mati865
commented
Aug 21, 2020
MemberAuthor
Works with ld.lld, fails with ld.bfd. I'll close that for now. |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Enable some of profiler tests on Windows-gnu CC rust-lang#61266 Because of force-push GitHub didn't let me reopen rust-lang#75184 Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI. However we can still test the IR for the proper instrumentation so let's do it.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Enable some of profiler tests on Windows-gnu CC rust-lang#61266 Because of force-push GitHub didn't let me reopen rust-lang#75184 Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI. However we can still test the IR for the proper instrumentation so let's do it.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2020
Enable some of profiler tests on Windows-gnu CC rust-lang#61266 Because of force-push GitHub didn't let me reopen rust-lang#75184 Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI. However we can still test the IR for the proper instrumentation so let's do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#61266
This will enable 10 tests (those with
needs-profiler-support), the time they take should be marginal but I can add it totryfirst if you want.