Uh oh!
There was an error while loading. Please reload this page.
Enable some of profiler tests on Windows-gnu - #75872
Merged
Merged
Conversation
mati865
commented
Aug 24, 2020
MemberAuthor
cc @richkadel for |
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
mati865
commented
Aug 31, 2020
MemberAuthor
@richkadel on which PR we are now waiting (I want to update the comment for triage team)? |
richkadel
commented
Aug 31, 2020
Sorry, right. The PR is #76004 . |
This comment has been minimized.
This comment has been minimized.
mati865force-pushed
the
pgo-tests
branch
2 times, most recently
from
September 4, 2020 13:14
c6286c8 to
3df676eComparemati865
commented
Sep 4, 2020
MemberAuthor
@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review |
petrochenkov
commented
Sep 4, 2020
Contributor
@bors r+ |
bors
commented
Sep 4, 2020
Collaborator
📌 Commit e8fc38d has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Enable some of profiler tests on Windows-gnu CC rust-lang#61266 Because of force-push GitHub didn't let me reopen rust-lang#75184 Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI. However we can still test the IR for the proper instrumentation so let's do it.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Enable some of profiler tests on Windows-gnu CC rust-lang#61266 Because of force-push GitHub didn't let me reopen rust-lang#75184 Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI. However we can still test the IR for the proper instrumentation so let's do it.
scottmcm
commented
Sep 5, 2020
Member
@bors r- rollup=iffy Rollup #76350 failed by something that seems suspiciously like it has to be this: On the mingw-windows builder only: https://github.com/rust-lang-ci/rust/runs/1074472443 |
mati865
commented
Sep 5, 2020
MemberAuthor
I don't think it's worth investigation whole fault this is: ancient GCC or ancient Binutils. |
petrochenkov
commented
Sep 5, 2020
Contributor
@bors r+ |
bors
commented
Sep 5, 2020
Collaborator
📌 Commit 5a51293 has been approved by |
bors
commented
Sep 5, 2020
Collaborator
bors
commented
Sep 5, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Sep 5, 2020
fmease added a commit
to fmease/rust
that referenced
this pull request
Jun 13, 2024
Don't build a broken/untested profiler runtime on mingw targets Context: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Why.20build.20a.20broken.2Funtested.20profiler.20runtime.20on.20mingw.3Frust-lang#75872 added `--enable-profiler` to the `x86_64-mingw` job (to cause some additional tests to run), but had to also add `//@ ignore-windows-gnu` to all of the tests that rely on the profiler runtime actually *working*, because it's broken on that target. We can achieve a similar outcome by going through all the `//@ needs-profiler-support` tests that don't actually need to produce/run a binary, and making them use `-Zno-profiler-runtime` instead, so that they can run even in configurations that don't have the profiler runtime available. Then we can remove `--enable-profiler` from `x86_64-mingw`, and still get the same amount of testing. This PR also removes `--enable-profiler` from the mingw dist builds, since it is broken/untested on that target. Those builds have had that flag for a very long time.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2024
Don't build a broken/untested profiler runtime on mingw targets Context: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Why.20build.20a.20broken.2Funtested.20profiler.20runtime.20on.20mingw.3Frust-lang#75872 added `--enable-profiler` to the `x86_64-mingw` job (to cause some additional tests to run), but had to also add `//@ ignore-windows-gnu` to all of the tests that rely on the profiler runtime actually *working*, because it's broken on that target. We can achieve a similar outcome by going through all the `//@ needs-profiler-support` tests that don't actually need to produce/run a binary, and making them use `-Zno-profiler-runtime` instead, so that they can run even in configurations that don't have the profiler runtime available. Then we can remove `--enable-profiler` from `x86_64-mingw`, and still get the same amount of testing. This PR also removes `--enable-profiler` from the mingw dist builds, since it is broken/untested on that target. Those builds have had that flag for a very long time.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
Don't build a broken/untested profiler runtime on mingw targets Context: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Why.20build.20a.20broken.2Funtested.20profiler.20runtime.20on.20mingw.3Frust-lang#75872 added `--enable-profiler` to the `x86_64-mingw` job (to cause some additional tests to run), but had to also add `//@ ignore-windows-gnu` to all of the tests that rely on the profiler runtime actually *working*, because it's broken on that target. We can achieve a similar outcome by going through all the `//@ needs-profiler-support` tests that don't actually need to produce/run a binary, and making them use `-Zno-profiler-runtime` instead, so that they can run even in configurations that don't have the profiler runtime available. Then we can remove `--enable-profiler` from `x86_64-mingw`, and still get the same amount of testing. This PR also removes `--enable-profiler` from the mingw dist builds, since it is broken/untested on that target. Those builds have had that flag for a very long time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC #61266
Because of force-push GitHub didn't let me reopen #75184
Because of the GCC miscompilation, generated binaries either segfault or
.profrawis malformed. Clang works fine but we can't use it on the CI.However we can still test the IR for the proper instrumentation so let's do it.