Display elided lifetime for non-reference type in doc

[nbdd0121]

In edition 2018 we encourage writing <'_> explicitly, so rustdoc should display like such as well.

Fixes#75225

Somehow when I run the compiled rustdoc using cargo +stage2 doc on other crates, it correctly produces <'_>, but I couldn't get the std doc to do the same with ./x.py doc --stage 2. Might this be related to the recent change to x.py about how the doc is built?

[rust-highfive]

r? @ollie27

(rust_highfive has picked a reviewer for you, use r? to override)

[jyn514]

Might this be related to the recent change to x.py about how the doc is built?

#73964 only changed the defaults, so if you used --stage 1 or --stage 2 it should have picked up the changes. That's weird they're not showing up ... Did you try doc --stage 2 library/std? This might have gotten hit by #73265.

[jyn514]

The changes themselves look great :)

[nbdd0121]

Did you try doc --stage 2 library/std?

That doesn't work either. I am totally confused now.

[nbdd0121]

Okay, it seems that I misunderstood the issue. It seems that the actual issue that imported docs still follow the old style, while items defined within the module follow the new style. So this PR works for core::cell::RefCell::borrow, alloc::vec::Vec::drain, std::sync::Mutex::lock, but not std::vec::Vec::drain or std::cell::RefCell::borrow. There must be something that I have missed.

[jyn514]

Try modifying this too:

rust/src/librustdoc/clean/utils.rs

Line 124 in 743f932

GenericArgKind::Lifetime(lt) => lt.clean(cx).map(GenericArg::Lifetime),

[nbdd0121]

Try modifying this too:

rust/src/librustdoc/clean/utils.rs

Line 124 in 743f932

GenericArgKind::Lifetime(lt) => lt.clean(cx).map(GenericArg::Lifetime),

Just discovered this myself 😂. Thanks anyway.

[jyn514]

Can you also add a test case for this on cross-crate item?

[nbdd0121]

Can you also add a test case for this on cross-crate item?

test5 and test6 are cross-crate.

[jyn514]

Oh I see, it doesn't have to do with re-exports, only with the original crate of the item.

@bors r+

[bors]

📌 Commit 505d157 has been approved by jyn514

[nbdd0121]

Oh sorry, it seems that it doesn't catch the case. Let me add a proper test for the re-export scenario.

[jyn514]

@bors r-

[jyn514]

Yeah, that looks like about the test case I expected.

@bors r+

[bors]

📌 Commit 541fbbb has been approved by jyn514