Uh oh!
There was an error while loading. Please reload this page.
Rename "Important traits" to "Notable traits" - #75344
Merged
bors merged 1 commit intoAug 10, 2020
Merged
Conversation
rust-highfive
commented
Aug 9, 2020
Contributor
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
rust-highfive
commented
Aug 9, 2020
Contributor
r? @ollie27 (rust_highfive has picked a reviewer for you, use r? to override) |
camelid
commented
Aug 9, 2020
MemberAuthor
r? @Manishearth |
GuillaumeGomez
requested changes
Aug 9, 2020
GuillaumeGomez
left a comment
Member
There was a problem hiding this comment.
Please remove all the JS format changes.
camelid
commented
Aug 9, 2020
MemberAuthor
@GuillaumeGomez Oops, thanks for catching that! VS Code must have done it... |
GuillaumeGomez
commented
Aug 9, 2020
Member
Don't worry, it's just very complicated to see the actual changes in the middle of all the formattings. ;) |
* Rename it in the UI * Rename the CSS classes
camelidforce-pushed
the
rename-important-to-notable-traits
branch
from
August 9, 2020 19:10
e5780f3 to
f3cc957Comparecamelid
commented
Aug 9, 2020
MemberAuthor
Fixed :) |
Manishearth
approved these changes
Aug 9, 2020
Manishearth
commented
Aug 9, 2020
Member
@bors r+ |
bors
commented
Aug 9, 2020
Collaborator
📌 Commit f3cc957 has been approved by |
GuillaumeGomez
commented
Aug 9, 2020
Member
@bors: rollup |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 10, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74200 (Std panicking unsafe block in unsafe fn) - rust-lang#75286 (Add additional case for Path starts with) - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope) - rust-lang#75320 (Detect likely `for foo of bar` JS syntax) - rust-lang#75328 (Cleanup E0749) - rust-lang#75344 (Rename "Important traits" to "Notable traits") - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs) - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#75245.