Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #75351
Merged
Merged
Conversation
This adds SAFETY comments where necessary, explaining the preconditions and how they are respected.
Show what happens if there is an extra extension
This has less surprising behavior when there is a module with the same name as a primitive in scope.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
* Rename it in the UI * Rename the CSS classes
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
…lock-in-unsafe-fn, r=Mark-Simulacrum Std panicking unsafe block in unsafe fn Partial fix of rust-lang#73904. This encloses `unsafe` operations in `unsafe fn` in `libstd/ffi/panicking.rs`. I also made a two lines change to `libstd/thread/local.rs` to add the necessary `unsafe` block without breaking everything else. @rustbot modify labels: F-unsafe-block-in-unsafe-fn
Add additional case for Path starts with Show what happens if there is an extra extension
Resolve `char` as a primitive even if there is a module in scope Closesrust-lang#58699. r? @Manishearth
Detect likely `for foo of bar` JS syntax Fixrust-lang#75311.
…an-DPC Cleanup E0749 r? @pickfire
…-traits, r=Manishearth Rename "Important traits" to "Notable traits" Fixesrust-lang#75245. --- * Rename it in the UI * Rename the CSS classes
…ime, r=jyn514 Move to intra-doc links in library/core/src/time.rs Helps with rust-lang#75080.
…r=davidtwco Do not ICE when lowering invalid extern fn with bodies Fixrust-lang#75283.
JohnTitor
commented
Aug 10, 2020
MemberAuthor
bors
commented
Aug 10, 2020
Collaborator
📌 Commit 5369619 has been approved by |
bors
commented
Aug 10, 2020
Collaborator
bors
commented
Aug 10, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
charas a primitive even if there is a module in scope #75318 (Resolvecharas a primitive even if there is a module in scope)for foo of barJS syntax #75320 (Detect likelyfor foo of barJS syntax)Failed merges:
r? @ghost