Enable ASLR for windows-gnu by mati865 · Pull Request #75406 · rust-lang/rust

mati865 · 2020-08-11T14:15:58Z

Fixes#16514
Fixes#16593
Fixes#17684

Passes the tests for me with x86_64 toolchain.

rust-highfive · 2020-08-11T14:16:02Z

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

kennytm · 2020-08-12T08:12:38Z

@bors try

bors · 2020-08-12T08:12:50Z

⌛ Trying commit 41e7b830c72706ac9967cb3307ef5937b8efe43b with merge 7cb9e7614df03dbbb4dae293eb27fcffa3df4987...

rust-log-analyzer · 2020-08-12T08:33:06Z

The job i686-mingw-1 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 Compiling gimli v0.22.0
Compiling miniz_oxide v0.4.0
Compiling object v0.20.0
Compiling addr2line v0.13.0
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
|
= note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--nxcompat" "-Wl,--dynamicbase" "-Wl,--high-entropy-va" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "-nostartfiles" "D:\\a\\rust\\rust\\mingw32\\i686-w64-mingw32\\lib\\dllcrt2.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "-L" "D:\\a\\rust\\rust\\mingw32\\i686-w64-mingw32\\lib" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\self-contained" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\std-001c7c07237f5a53.std.2oi95g00-cgu.0.rcgu.o" "-o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\std-001c7c07237f5a53.dll" "-Wl,C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\list.def" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\std-001c7c07237f5a53.2hraozlwyo1yhfwv.rcgu.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\std-001c7c07237f5a53.1hjeje4fj01jxwde.rcgu.o" "-shared" "-Wl,--out-implib,D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\libstd-001c7c07237f5a53.dll.a" "-nodefaultlibs" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\release\\deps" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\build\\compiler_builtins-9c3d08aa6513a296\\out" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-ladvapi32" "-lws2_32" "-luserenv" "-Wl,-Bstatic" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libpanic_unwind-b835dd322c68c1f1.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libobject-39cb832dd7b4fe6c.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libaddr2line-4c97ef5a0e76d72a.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libgimli-2fe4a88c7896e835.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\librustc_demangle-64d2fa27da74b60c.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libhashbrown-a5eaa47a1565eb3e.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\librustc_std_workspace_alloc-62f28998d5602550.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libunwind-1cae5105b9d9a6cf.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libcfg_if-a8c586b295602734.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\liblibc-ecd3b8c387994089.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\liballoc-cab34448e6c5a1a9.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\librustc_std_workspace_core-b320f0b9b23c3ba1.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libcore-bd38834d04123d9c.rlib" "-Wl,--no-whole-archive" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustchXSkpj\\libcompiler_builtins-4ad5645d782c03f2.rlib" "-Wl,-Bdynamic" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lmsvcrt" "-luser32" "-lkernel32" "-lgcc_s" "-lgcc" "-lkernel32" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
= note: D:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/6.3.0/../../../../i686-w64-mingw32/bin/ld.exe: unrecognized option '--high-entropy-va'
D:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/6.3.0/../../../../i686-w64-mingw32/bin/ld.exe: use the --help option for usage information
collect2.exe: error: ld returned 1 exit status
error: aborting due to previous error
error: could not compile `std`.
To learn more, run the command again with --verbose.
command did not execute successfully: "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage0\\bin\\cargo.exe" "build" "--target" "i686-pc-windows-gnu" "-Zbinary-dep-depinfo" "-j" "8" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "D:\\a\\rust\\rust\\library/test/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: D:\a\rust\rust\build\bootstrap\debug\bootstrap test --stage 2 --exclude src/test/ui --exclude src/test/compile-fail
Build completed unsuccessfully in 0:16:31
Build completed unsuccessfully in 0:16:31
make: *** [Makefile:82: ci-mingw-subset-1] Error 1
local time: Wed Aug 12 08:32:58 CUT 2020
network time: Wed, 12 Aug 2020 08:32:58 GMT
== end clock drift check ==
== end clock drift check ==
##[error]Process completed with exit code 2.
Terminate orphan process: pid (4700) (python)
Terminate orphan process: pid (1464) (sccache)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-08-12T08:33:34Z

💔 Test failed - checks-actions

mati865 · 2020-08-12T09:21:01Z

LLD ignores --high-entropy-va when linking 32 bit binaries but LD apparently throws the error.

Force pushed to enable high entropy only on 64 bit targets.

kennytm · 2020-08-12T19:54:23Z

@bors try

bors · 2020-08-12T19:54:37Z

⌛ Trying commit 372725d05a26a4a1350efec8943c93aec8fd5633 with merge b5ba1d6ee3722c4f81fecc22d300e07ba401af02...

bors · 2020-08-12T21:05:42Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: b5ba1d6ee3722c4f81fecc22d300e07ba401af02 (b5ba1d6ee3722c4f81fecc22d300e07ba401af02)

mati865 · 2020-08-12T21:55:09Z

Looks good but I don't know who would be the right reviewer here.
There are 2 weeks to beta so I think it would be nice if this landed soonish and was reverted for beta so we have more than 6 weeks of testing here.

crlf0710 · 2020-08-28T18:44:50Z

Ping from triage, there's merge conflicts now.

mati865 · 2020-08-31T12:32:36Z

FWIW LLD recently enabled ASLR by default and Binutils followed.

Dylan-DPC-zz · 2020-09-15T12:55:01Z

@bors try

bors · 2020-09-15T12:55:15Z

⌛ Trying commit 0ad3da0 with merge 7beae27597059d3c7a90c62c24c93fdaaafc2d1b...

bors · 2020-09-15T13:39:58Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: 7beae27597059d3c7a90c62c24c93fdaaafc2d1b (7beae27597059d3c7a90c62c24c93fdaaafc2d1b)

Dylan-DPC-zz · 2020-10-10T23:35:31Z

r? @Mark-Simulacrum

Mark-Simulacrum · 2020-10-13T13:05:10Z

I am inclined to just land this -- certainly seems like an improvement.

I agree that getting this tested for longer would be good; we can let it land in 1.50 (as opposed to 1.49) for example, though I am likely to forget about this by the time we promote master to beta in ~5 weeks.

@bors r+ rollup=never

bors · 2020-10-13T13:05:19Z

📌 Commit 0ad3da0 has been approved by Mark-Simulacrum

bors · 2020-10-13T14:12:15Z

⌛ Testing commit 0ad3da0 with merge d65c08e...

mati865 · 2020-10-13T14:42:47Z

I agree that getting this tested for longer would be good; we can let it land in 1.50 (as opposed to 1.49) for example, though I am likely to forget about this by the time we promote master to beta in ~5 weeks.

I'll set up reminder if it lands.

bors · 2020-10-13T16:09:38Z

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing d65c08e to master...

rust-highfive assigned kennytm Aug 11, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2020

mati865 force-pushed the mingw-aslr branch from 41e7b83 to 372725dCompare August 12, 2020 09:17

mati865 force-pushed the mingw-aslr branch from 372725d to 067ddb7Compare August 28, 2020 21:54

This comment has been minimized.
Sign in to view

Enable ASLR for windows-gnu
0ad3da0

mati865 force-pushed the mingw-aslr branch from 067ddb7 to 0ad3da0Compare August 31, 2020 12:31

mati865 mentioned this pull request Sep 7, 2020
Update Rust to 1.48 msys2/MINGW-packages#6932
Merged

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020

rust-highfive assigned Mark-Simulacrum and unassigned kennytm Oct 10, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 13, 2020

bors merged commit d65c08e into rust-lang:masterOct 13, 2020

rustbot added this to the 1.49.0 milestone Oct 13, 2020

mati865 deleted the mingw-aslr branch October 13, 2020 18:06

mati865 mentioned this pull request Nov 17, 2020
[beta] Revert "Enable ASLR for windows-gnu" #79141
Closed

petrochenkov mentioned this pull request Nov 18, 2020
Fresh MSYS2 gdb cannot set a breakpoint in Rust executables #79112
Closed

Uh oh!

Uh oh!

Conversation

mati865 commented Aug 11, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Aug 11, 2020

Uh oh!

kennytm commented Aug 12, 2020

Uh oh!

bors commented Aug 12, 2020

Uh oh!

rust-log-analyzer commented Aug 12, 2020

Uh oh!

bors commented Aug 12, 2020

Uh oh!

mati865 commented Aug 12, 2020

Uh oh!

kennytm commented Aug 12, 2020

Uh oh!

bors commented Aug 12, 2020

Uh oh!

bors commented Aug 12, 2020

Uh oh!

mati865 commented Aug 12, 2020

Uh oh!

crlf0710 commented Aug 28, 2020

Uh oh!

This comment has been minimized.

mati865 commented Aug 31, 2020

Uh oh!

Dylan-DPC-zz commented Sep 15, 2020

Uh oh!

bors commented Sep 15, 2020

Uh oh!

bors commented Sep 15, 2020

Uh oh!

Dylan-DPC-zz commented Oct 10, 2020

Uh oh!

Mark-Simulacrum commented Oct 13, 2020

Uh oh!

bors commented Oct 13, 2020

Uh oh!

bors commented Oct 13, 2020

Uh oh!

mati865 commented Oct 13, 2020

Uh oh!

bors commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mati865 commented Aug 11, 2020•
edited
Loading