Skip to content

[beta] Revert "Enable ASLR for windows-gnu" - #79141

Closed
mati865 wants to merge 1 commit into
rust-lang:betafrom
mati865:mingw-beta-revert-aslr
Closed

[beta] Revert "Enable ASLR for windows-gnu"#79141
mati865 wants to merge 1 commit into
rust-lang:betafrom
mati865:mingw-beta-revert-aslr

Conversation

@mati865

@mati865mati865 commented Nov 17, 2020

Copy link
Copy Markdown
Member

This reverts commit 0ad3da0.

Per #75406 (comment)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2020
@jyn514jyn514 changed the title Revert "Enable ASLR for windows-gnu"[beta] Revert "Enable ASLR for windows-gnu"Nov 17, 2020
@jyn514jyn514 added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-windows-gnu Toolchain: GNU, Operating system: Windows T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 17, 2020
This was referenced Nov 18, 2020
@Mark-SimulacrumMark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 19, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

(Marking with beta labels though it's targeting beta branch already, I will pick this up in next round of backports).

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

Included in backport PR going up shortly, closing this.

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Dec 8, 2020
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 8, 2020
@mati865
mati865 deleted the mingw-beta-revert-aslr branch December 8, 2020 22:06
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2020
…ulacrum
[beta] backports
* [beta] always disable copy_file_range to avoid EOVERFLOW errors rust-lang#79008
* Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio rust-lang#77801
* bootstrap: use the same version number for rustc and cargo rust-lang#79133
* [beta] Revert "Enable ASLR for windows-gnu" rust-lang#79141
* [beta] revert rust-lang#78790, vendor libtest for rustc-src rust-lang#79571
* Mirror centos vault to S3 rust-lang#79435
* [beta] Update cargo rust-lang#79739
This also bumps to non-dev stable compiler.
r? `@ghost`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-runtimeArea: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflowsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-windows-gnuToolchain: GNU, Operating system: WindowsT-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mati865@rust-highfive@Mark-Simulacrum@jyn514