Uh oh!
There was an error while loading. Please reload this page.
Recover gracefully from struct parse errors - #75513
Merged
Merged
Conversation
rust-highfive
commented
Aug 14, 2020
Contributor
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
struct parse errorsstruct parse errorsdavidtwco
approved these changes
Aug 14, 2020
davidtwco
commented
Aug 14, 2020
Member
@bors r+ |
bors
commented
Aug 14, 2020
Collaborator
📌 Commit 2e9b45e has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#75376 (Set CMAKE_SYSTEM_NAME when cross-compiling) - rust-lang#75448 (merge `as_local_hir_id` with `local_def_id_to_hir_id`) - rust-lang#75513 (Recover gracefully from `struct` parse errors) - rust-lang#75545 (std/sys/unix/time: make it easier for LLVM to optimize `Instant` subtraction.) Failed merges: - rust-lang#75514 (Replaced `log` with `tracing`) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the parser tries to recover from finding a keyword where a field name was expected, but this causes extra knock down parse errors that are completely irrelevant. Instead, bail out early in the parsing of the field and consume the remaining tokens in the block. This can reduce output significantly.
Improvements based on the narrative in https://fasterthanli.me/articles/i-am-a-java-csharp-c-or-cplusplus-dev-time-to-do-some-rust