Skip to content

Replaced log with tracing - #75514

Merged
bors merged 1 commit into
rust-lang:masterfrom
gdhuper:gdhuper/replace_log_with_tracing
Aug 15, 2020
Merged

Replaced log with tracing#75514
bors merged 1 commit into
rust-lang:masterfrom
gdhuper:gdhuper/replace_log_with_tracing

Conversation

@gdhuper

@gdhupergdhuper commented Aug 14, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Replaced log with tracing in the following crates:

  • librustc_ast
  • librustc_driver
  • librustc_errors
  • librustc_expand
  • librustc_hir
  • librustc_incremental
  • librustc_infer
  • librustc_interface
  • librustc_lint
  • librustc_metadata
  • librustc_middle
  • librustc_mir
  • librustc_mir_build
  • librustc_parse
  • librustc_passes
  • librustc_privacy
  • librustc_query_system
  • librustc_resolve
  • librustc_save_analysis
  • librustc_session
  • librustc_span
  • librustc_symbol_mangling
  • librustc_target
  • librustc_trait_selection
  • librustc_traits
  • librustc_ty
  • librustc_typeck
  • compiletest

Fixes: #74747

Checklist:

  • Code compiles / builds
  • run tidy
  • Cleanup any clippy warnings
  • Update/add docs

@rust-highfive

rust-highfive commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
@gdhuper
gdhuper marked this pull request as ready for review August 14, 2020 06:41
@davidtwco

davidtwco commented Aug 14, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 14, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit c5ba2128d854032f843e9532ffa663ab4dc41fd8 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2020
@tmandrytmandry mentioned this pull request Aug 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 15, 2020
@bors
Auto merge ofrust-lang#75549- tmandry:rollup-sxjwa0w, r=tmandry
45060c2
Rollup of 4 pull requests
Successful merges:
- rust-lang#75376 (Set CMAKE_SYSTEM_NAME when cross-compiling)
- rust-lang#75448 (merge `as_local_hir_id` with `local_def_id_to_hir_id`)
- rust-lang#75513 (Recover gracefully from `struct` parse errors)
- rust-lang#75545 (std/sys/unix/time: make it easier for LLVM to optimize `Instant` subtraction.)
Failed merges:
- rust-lang#75514 (Replaced `log` with `tracing`)
r? @ghost
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2020
@crlf0710

crlf0710 commented Aug 15, 2020

Copy link
Copy Markdown
Member

@gdhuper A rebase is needed since we're don't accept PRs with merge commits in them.

@gdhuper

gdhuper commented Aug 15, 2020

Copy link
Copy Markdown
ContributorAuthor

@gdhuper A rebase is needed since we're don't accept PRs with merge commits in them.

@crlf0710 Thanks for the heads up. I didn't know this. Should I cherry pick previous commit and then rebase or recreate a branch?

@mati865

mati865 commented Aug 15, 2020

Copy link
Copy Markdown
Member

@gdhuper in your case git rebase <rust-lang-name>/master (replace rust-lang-name with the name you have configured for https://github.com/rust-lang/rust.git) and that should remove merge commit.

@gdhuper
gdhuperforce-pushed the gdhuper/replace_log_with_tracing branch from ea15c3f to d2753f9CompareAugust 15, 2020 20:05
@davidtwco

davidtwco commented Aug 15, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d2753f9 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2020
@bors

bors commented Aug 15, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d2753f9 with merge 9b88e0a...

@bors

bors commented Aug 15, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 9b88e0a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2020
@bors
bors merged commit 9b88e0a into rust-lang:masterAug 15, 2020
@borsbors mentioned this pull request Aug 16, 2020
Merged
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

Remove log renamings of tracing crate

7 participants

@gdhuper@rust-highfive@davidtwco@bors@crlf0710@mati865@cuviper