Skip to content

Use more compatible out-implib style - #75603

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:mingw-out-implib-compat
Aug 18, 2020
Merged

Use more compatible out-implib style#75603
bors merged 1 commit into
rust-lang:masterfrom
mati865:mingw-out-implib-compat

Conversation

@mati865

Copy link
Copy Markdown
Member

When calling rust-lld directly it accepts only --out-implib {} or --out-implib={} not --out-implib,{}.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 17, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1627ba1 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2020
@tmandrytmandry mentioned this pull request Aug 18, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2020
Rollup of 3 pull requests
Successful merges:
- rust-lang#75548 (librustc_metadata::locator: Properly detect file type.)
- rust-lang#75603 (Use more compatible out-implib style)
- rust-lang#75637 (update stacker to 0.1.11 to unbreak build for wasm32-unknown-unknown)
Failed merges:
r? @ghost
@bors
bors merged commit d70ae9b into rust-lang:masterAug 18, 2020
@mati865
mati865 deleted the mingw-out-implib-compat branch August 18, 2020 06:05
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mati865@rust-highfive@oli-obk@bors@cuviper