Uh oh!
There was an error while loading. Please reload this page.
Rollup of 3 pull requests - #75654
Merged
Merged
Conversation
Make sure to test for file types against the non-canonicalized name to avoid detecting the wrong type. Some systems save build artifacts into associative file stores that do not preserve extensions, and then link to those using conventionally-named symbolic links that are the arguments to `rustc` et al. If we canonicalize before testing the type, we resolve the symlink, the extension is lost and we might treat rlibs and rmetas as dylibs. The fix is to introduce a temporary to hold the canonicalized name, compare against the non-canonical name, and add a comment explaining what's going on for the would-be maintainer who sees a potential cleanup. Signed-off-by: Dan Cross <dcross@google.com>
librustc_metadata::locator: Properly detect file type. Make sure to test file types against the non-canonicalized name to avoid detecting the wrong type. Some systems save build artifacts into associate file stores that do not preserve extensions, and then link to those using conventionally-named symbolic links, that are the arguments to `rustc` et al. If we canonicalize before testing the type, we resolve the symlink, the extension is lost and we might treat rlibs and rmetas as dylibs. The fix is to tntroduce a temporary to hold the canonicalized name, compare against the non-canonical name, and add a comment explaining what's going on for the would-be mainter who sees a potential cleanup. Signed-off-by: Dan Cross <dcross@google.com>
…oli-obk
Use more compatible out-implib style
When calling `rust-lld` directly it accepts only `--out-implib {}` or `--out-implib={}` not `--out-implib,{}`.…crum update stacker to 0.1.11 to unbreak build for wasm32-unknown-unknown Like rust-lang#72079, this updates stacker. The related problem is stacker is here rust-lang/stacker#42. It was fixed by switching from `libc::c_void` to `std::ffi::c_void` https://github.com/rust-lang/stacker/pull/43/files.
tmandry
commented
Aug 18, 2020
MemberAuthor
bors
commented
Aug 18, 2020
Collaborator
📌 Commit 14c0e4c has been approved by |
bors
commented
Aug 18, 2020
Collaborator
bors
commented
Aug 18, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost