Skip to content

Add doc examples coverage - #75665

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:doc-examples-coverage
Aug 19, 2020
Merged

Add doc examples coverage#75665
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:doc-examples-coverage

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2020
@jyn514jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 18, 2020

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm impressed how little code this is! One small nit, and the build is failing, you might need to run rustfmt or something.

Comment threadsrc/librustdoc/passes/calculate_doc_coverage.rs Outdated
@jyn514

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f957bae has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2020
@tmandrytmandry mentioned this pull request Aug 18, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 18, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 18, 2020
@tmandrytmandry mentioned this pull request Aug 18, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandrytmandry mentioned this pull request Aug 19, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandrytmandry mentioned this pull request Aug 19, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandrytmandry mentioned this pull request Aug 19, 2020
@JohnTitorJohnTitor mentioned this pull request Aug 19, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2020
Rollup of 9 pull requests
Successful merges:
- rust-lang#75038 (See also X-Link mem::{swap, take, replace})
- rust-lang#75049 (docs(marker/copy): provide example for `&T` being `Copy`)
- rust-lang#75499 (Fix documentation error)
- rust-lang#75554 (Fix clashing_extern_declarations stack overflow for recursive types.)
- rust-lang#75646 (Move to intra doc links for keyword documentation)
- rust-lang#75652 (Resolve true and false as booleans)
- rust-lang#75658 (Don't emit "is not a logical operator" error outside of associative expressions)
- rust-lang#75665 (Add doc examples coverage)
- rust-lang#75685 (Switch to intra-doc links in /src/sys/unix/ext/*.rs)
Failed merges:
r? @ghost
@bors
bors merged commit 98f7d88 into rust-lang:masterAug 19, 2020
@GuillaumeGomez
GuillaumeGomez deleted the doc-examples-coverage branch August 19, 2020 09:49
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@jyn514@bors@cuviper@rust-highfive