Skip to content

Switch to intra-doc links in /src/sys/unix/ext/*.rs - #75685

Merged
bors merged 2 commits into
rust-lang:masterfrom
nixphix:docs/unix-ext
Aug 19, 2020
Merged

Switch to intra-doc links in /src/sys/unix/ext/*.rs#75685
bors merged 2 commits into
rust-lang:masterfrom
nixphix:docs/unix-ext

Conversation

@nixphix

@nixphixnixphix commented Aug 19, 2020

Copy link
Copy Markdown
Contributor

Partial fix for #75080

@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc

r? @jyn514

These two links are not resolving to either crate::fs::File... or fs::File...

# unix/ext/fs.rs
27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read
130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write

@rustbotrustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 19, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020
@jyn514

jyn514 commented Aug 19, 2020

Copy link
Copy Markdown
Member

These two links are not resolving to either crate::fs::File... or fs::File...

This is #74489.

@nixphix
nixphix marked this pull request as ready for review August 19, 2020 00:42
jyn514
jyn514 reviewed Aug 19, 2020
View reviewed changes
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
Comment threadlibrary/std/src/sys/unix/ext/net.rs Outdated
@jyn514

jyn514 commented Aug 19, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 19, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 63d2e9b has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge ofrust-lang#75685- nixphix:docs/unix-ext, r=jyn514
5013e01
Switch to intra-doc links in /src/sys/unix/ext/*.rs
Partial fix for rust-lang#75080@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
These two links are not resolving to either `crate::fs::File...` or `fs::File...`
```
# unix/ext/fs.rs
27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read
130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write
```
@tmandrytmandry mentioned this pull request Aug 19, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge ofrust-lang#75685- nixphix:docs/unix-ext, r=jyn514
beafa65
Switch to intra-doc links in /src/sys/unix/ext/*.rs
Partial fix for rust-lang#75080@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
These two links are not resolving to either `crate::fs::File...` or `fs::File...`
```
# unix/ext/fs.rs
27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read
130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write
```
@tmandrytmandry mentioned this pull request Aug 19, 2020
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Aug 19, 2020
@tmandry
Rollup merge ofrust-lang#75685- nixphix:docs/unix-ext, r=jyn514
fedadbc
Switch to intra-doc links in /src/sys/unix/ext/*.rs
Partial fix for rust-lang#75080@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
These two links are not resolving to either `crate::fs::File...` or `fs::File...`
```
# unix/ext/fs.rs
27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read
130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write
```
@tmandrytmandry mentioned this pull request Aug 19, 2020
Closed
@JohnTitorJohnTitor mentioned this pull request Aug 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2020
@bors
Auto merge ofrust-lang#75692- JohnTitor:rollup-8gr04ah, r=JohnTitor
5b04bbf
Rollup of 9 pull requests
Successful merges:
- rust-lang#75038 (See also X-Link mem::{swap, take, replace})
- rust-lang#75049 (docs(marker/copy): provide example for `&T` being `Copy`)
- rust-lang#75499 (Fix documentation error)
- rust-lang#75554 (Fix clashing_extern_declarations stack overflow for recursive types.)
- rust-lang#75646 (Move to intra doc links for keyword documentation)
- rust-lang#75652 (Resolve true and false as booleans)
- rust-lang#75658 (Don't emit "is not a logical operator" error outside of associative expressions)
- rust-lang#75665 (Add doc examples coverage)
- rust-lang#75685 (Switch to intra-doc links in /src/sys/unix/ext/*.rs)
Failed merges:
r? @ghost
@bors
bors merged commit 07ea340 into rust-lang:masterAug 19, 2020
@jyn514jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nixphix@jyn514@bors@cuviper@rust-highfive@rustbot