Skip to content

Refactor byteorder to std in rustc_middle - #75741

Merged
bors merged 5 commits into
rust-lang:masterfrom
workingjubilee:refactor-byteorder
Sep 5, 2020
Merged

Refactor byteorder to std in rustc_middle#75741
bors merged 5 commits into
rust-lang:masterfrom
workingjubilee:refactor-byteorder

Conversation

@workingjubilee

@workingjubileeworkingjubilee commented Aug 20, 2020

Copy link
Copy Markdown
Member

Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.

@rust-highfive

rust-highfive commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@workingjubilee
workingjubileeforce-pushed the refactor-byteorder branch 3 times, most recently from 09f6b30 to 3f4e682CompareAugust 20, 2020 12:58
tesuji
tesuji reviewed Aug 20, 2020
View reviewed changes
Comment threadsrc/librustc_middle/mir/interpret/allocation.rs Outdated
matklad
matklad reviewed Aug 20, 2020
View reviewed changes
Comment threadsrc/librustc_middle/mir/interpret/mod.rs Outdated
@workingjubilee
workingjubileeforce-pushed the refactor-byteorder branch 2 times, most recently from 0f08382 to cb4673dCompareAugust 20, 2020 23:22
crlf0710
crlf0710 reviewed Aug 21, 2020
View reviewed changes
Comment threadsrc/librustc_middle/mir/interpret/mod.rs Outdated
crlf0710
crlf0710 reviewed Aug 21, 2020
View reviewed changes
Comment threadsrc/librustc_middle/mir/interpret/mod.rs Outdated
matthewjasper
matthewjasper reviewed Aug 22, 2020
View reviewed changes
Comment threadsrc/librustc_middle/mir/interpret/mod.rs Outdated
Comment threadsrc/librustc_middle/mir/interpret/mod.rs Outdated
@bors

bors commented Aug 30, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee
workingjubileeforce-pushed the refactor-byteorder branch 2 times, most recently from 2f7654e to b688314CompareAugust 31, 2020 04:07
@matthewjasper

matthewjasper commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b688314 has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge ofrust-lang#75741- workingjubilee:refactor-byteorder, …
e818838
…r=matthewjasper
Refactor byteorder to std in rustc_middle
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
@bors

bors commented Sep 5, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #75173) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2020
@workingjubilee
Refactor byteorder to std in rustc_middle
b97d413
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
@workingjubilee
Remove reference to byteorder limits
74b4eea
workingjubileeand others added 3 commits September 4, 2020 21:51
@workingjubilee@matklad
Be explicit that we're handling bytes
fe2a867
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@workingjubilee
Explain contract of {read, write}_target_uint
dc00eff
@workingjubilee@matthewjasper
Fix big endian read/write
2df552b
Co-authored-by: matthewjasper <mjjasper1@gmail.com>
@workingjubilee

workingjubilee commented Sep 5, 2020

Copy link
Copy Markdown
MemberAuthor

bors plz.
@bors r+ <_<
OK that probably won't work but
@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review
might.

@bors

bors commented Sep 5, 2020

Copy link
Copy Markdown
Collaborator

@workingjubilee: 🔑 Insufficient privileges: Not in reviewers

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2020
@matthewjasper

matthewjasper commented Sep 5, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2df552b has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
@Dylan-DPC
Rollup merge ofrust-lang#75741- workingjubilee:refactor-byteorder, …
b1b4512
…r=matthewjasper
Refactor byteorder to std in rustc_middle
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
This was referenced Sep 5, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2020
@bors
Auto merge ofrust-lang#76376- Dylan-DPC:rollup-8chsbw9, r=Dylan-DPC
7d289ae
Rollup of 11 pull requests
Successful merges:
- rust-lang#75695 (Add a regression test for issue-72793)
- rust-lang#75741 (Refactor byteorder to std in rustc_middle)
- rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features)
- rust-lang#75994 (`impl Rc::new_cyclic`)
- rust-lang#76060 (Link vec doc to & reference)
- rust-lang#76078 (Remove disambiguators from intra doc link text)
- rust-lang#76082 (Fix intra-doc links on pub re-exports)
- rust-lang#76254 (Fold length constant in Rvalue::Repeat)
- rust-lang#76258 (x.py check checks tests/examples/benches)
- rust-lang#76263 (inliner: Check for codegen fn attributes compatibility)
- rust-lang#76285 (Move jointness censoring to proc_macro)
Failed merges:
r? @ghost
@bors
bors merged commit e160d2b into rust-lang:masterSep 5, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 5, 2020
@workingjubilee
workingjubilee deleted the refactor-byteorder branch April 23, 2021 19:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crlf0710crlf0710crlf0710 left review comments
@matthewjaspermatthewjaspermatthewjasper left review comments
+2 more reviewers
@matkladmatkladmatklad left review comments
@tesujitesujitesuji left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@matthewjaspermatthewjasper

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

8 participants

@workingjubilee@rust-highfive@bors@matthewjasper@crlf0710@matklad@tesuji@rustbot