Skip to content

inliner: Check for codegen fn attributes compatibility - #76263

Merged
bors merged 3 commits into
rust-lang:masterfrom
tmiasko:inline-codegen-fn-attrs
Sep 5, 2020
Merged

inliner: Check for codegen fn attributes compatibility#76263
bors merged 3 commits into
rust-lang:masterfrom
tmiasko:inline-codegen-fn-attrs

Conversation

@tmiasko

Copy link
Copy Markdown
Contributor
  • Check for target features compatibility
  • Check for no_sanitize attribute compatibility

Fixes#76259.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2020
@tmiasko
tmiaskoforce-pushed the inline-codegen-fn-attrs branch from 060a2dc to ae8018eCompareSeptember 3, 2020 00:26
@tmiasko

Copy link
Copy Markdown
ContributorAuthor

r? @ecstatic-morse

@ecstatic-morseecstatic-morse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a question and a style nit.

Comment threadcompiler/rustc_mir/src/transform/inline.rs Outdated
Comment threadcompiler/rustc_mir/src/transform/inline.rs Outdated
@tmiasko
tmiaskoforce-pushed the inline-codegen-fn-attrs branch from ae8018e to c23151bCompareSeptember 4, 2020 18:46
@ecstatic-morse

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+

@bors

bors commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit c23151b has been approved by ecstatic-morse

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
…ecstatic-morse
inliner: Check for codegen fn attributes compatibility
* Check for target features compatibility
* Check for no_sanitize attribute compatibility
Fixesrust-lang#76259.
This was referenced Sep 5, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2020
Rollup of 11 pull requests
Successful merges:
- rust-lang#75695 (Add a regression test for issue-72793)
- rust-lang#75741 (Refactor byteorder to std in rustc_middle)
- rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features)
- rust-lang#75994 (`impl Rc::new_cyclic`)
- rust-lang#76060 (Link vec doc to & reference)
- rust-lang#76078 (Remove disambiguators from intra doc link text)
- rust-lang#76082 (Fix intra-doc links on pub re-exports)
- rust-lang#76254 (Fold length constant in Rvalue::Repeat)
- rust-lang#76258 (x.py check checks tests/examples/benches)
- rust-lang#76263 (inliner: Check for codegen fn attributes compatibility)
- rust-lang#76285 (Move jointness censoring to proc_macro)
Failed merges:
r? @ghost
@bors
bors merged commit b4d3873 into rust-lang:masterSep 5, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 5, 2020
@tmiasko
tmiasko deleted the inline-codegen-fn-attrs branch September 5, 2020 17:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLVM ERROR: Do not know how to split this operator's operand! with -Zmir-opt-level=2

6 participants

@tmiasko@rust-highfive@ecstatic-morse@bors@nikomatsakis@rustbot