Skip to content

Use intra-doc-links in core::{char, macros, fmt} - #75819

Merged
bors merged 1 commit into
rust-lang:masterfrom
LeSeulArtichaut:core-intra-docs-2
Aug 24, 2020
Merged

Use intra-doc-links in core::{char, macros, fmt}#75819
bors merged 1 commit into
rust-lang:masterfrom
LeSeulArtichaut:core-intra-docs-2

Conversation

@LeSeulArtichaut

@LeSeulArtichautLeSeulArtichaut commented Aug 22, 2020

Copy link
Copy Markdown
Contributor

Helps with #75080.
r? @jyn514

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2020
jyn514
jyn514 reviewed Aug 22, 2020
View reviewed changes

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #75815, but no helping that since prim@ doesn't exist yet. Looks fine otherwise.

Comment threadlibrary/core/src/macros/mod.rs Outdated
Comment threadlibrary/core/src/macros/mod.rs Outdated
@jyn514jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 22, 2020
jyn514
jyn514 reviewed Aug 22, 2020
View reviewed changes

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit

Comment threadlibrary/core/src/fmt/mod.rs Outdated
@jyn514

jyn514 commented Aug 22, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 6d22ce158f47716191492d02da0803e9baf33d59 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020
@jyn514

jyn514 commented Aug 22, 2020

Copy link
Copy Markdown
Member

@bors r-

I need to start waiting for CI 😆

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2020
@LeSeulArtichaut
LeSeulArtichautforce-pushed the core-intra-docs-2 branch 2 times, most recently from 1a54979 to 56b7c5cCompareAugust 23, 2020 21:01
@LeSeulArtichaut

LeSeulArtichaut commented Aug 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Alright, this time there is NO reason why CI won't pass :D

@jyn514

jyn514 commented Aug 23, 2020

Copy link
Copy Markdown
Member
alloc/fmt/trait.Write.html:12: broken link - alloc/fmt/crate::write!
alloc/fmt/trait.Write.html:53: broken link - alloc/fmt/crate::write!
alloc/fmt/trait.Write.html:55: broken link - alloc/fmt/crate::write!
alloc/fmt/fn.write.html:16: broken link - alloc/fmt/crate::write!
alloc/fmt/struct.Formatter.html:365: broken link - alloc/fmt/crate::format_args

This is #75176.

@LeSeulArtichautLeSeulArtichaut mentioned this pull request Aug 23, 2020
Merged
@jyn514

jyn514 commented Aug 23, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d36e3e2 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2020
@jyn514

jyn514 commented Aug 23, 2020

Copy link
Copy Markdown
Member

Note to anyone making rollups: this will cause conflicts with #75815, so they shouldn't be placed in the same rollup.

@jyn514jyn514 mentioned this pull request Aug 23, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2020
@JohnTitor
Rollup merge ofrust-lang#75819- LeSeulArtichaut:core-intra-docs-2, …
9576eef
…r=jyn514
Use intra-doc-links in `core::{char, macros, fmt}`
Helps with rust-lang#75080.
r? @jyn514
@JohnTitorJohnTitor mentioned this pull request Aug 24, 2020
Closed
@JohnTitorJohnTitor mentioned this pull request Aug 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2020
@bors
Auto merge ofrust-lang#75865- JohnTitor:rollup-yxia6d2, r=JohnTitor
c4b6d94
Rollup of 10 pull requests
Successful merges:
- rust-lang#75819 (Use intra-doc-links in `core::{char, macros, fmt}`)
- rust-lang#75821 (Switch to intra-doc links in `std::macros`)
- rust-lang#75825 (Fix typo in documentation of i32 wrapping_abs())
- rust-lang#75826 (Corrected Misleading documentation for derived Ord/PartialOrd implementation )
- rust-lang#75831 (doc: Prefer https link for wikipedia URLs)
- rust-lang#75844 (publish-toolstate: show more context on HTTP error)
- rust-lang#75847 (Switch to intra-doc links in `std::collections`)
- rust-lang#75851 (Switch to intra-doc links in `core::array`)
- rust-lang#75856 (more tool clippy fixes)
- rust-lang#75859 (doc: Fix typo in std::process::Child documentation)
Failed merges:
r? @ghost
@bors
bors merged commit 50bdcc2 into rust-lang:masterAug 24, 2020
@LeSeulArtichaut
LeSeulArtichaut deleted the core-intra-docs-2 branch August 24, 2020 08:01
@jyn514jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@camelidcamelid mentioned this pull request Aug 26, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 5, 2020
@Dylan-DPC
Rollup merge ofrust-lang#75853- LeSeulArtichaut:core-intra-docs-3, …
6c9e857
…r=jyn514
Use more intra-doc-links in `core::fmt`
This is a follow-up to rust-lang#75819, which encountered some broken links due to rust-lang#75176, so this PR contains the links that are blocked on rust-lang#75176.
r? @jyn514
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

5 participants

@LeSeulArtichaut@jyn514@bors@cuviper@rust-highfive