Skip to content

Corrected Misleading documentation for derived Ord/PartialOrd implementation - #75826

Merged
bors merged 1 commit into
rust-lang:masterfrom
ayushmishra2005:misleading_documentation_for_derived_Ord_PartialOrd
Aug 24, 2020
Merged

Corrected Misleading documentation for derived Ord/PartialOrd implementation #75826
bors merged 1 commit into
rust-lang:masterfrom
ayushmishra2005:misleading_documentation_for_derived_Ord_PartialOrd

Conversation

@ayushmishra2005

Copy link
Copy Markdown
Contributor

Corrected Misleading documentation for derived Ord/PartialOrd implementation

Fixes#75620

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2020
Comment threadlibrary/core/src/cmp.rs Outdated
Comment threadlibrary/core/src/cmp.rs Outdated
@ayushmishra2005
ayushmishra2005force-pushed the misleading_documentation_for_derived_Ord_PartialOrd branch from 69896ef to 18f47d8CompareAugust 23, 2020 10:27
@ayushmishra2005

Copy link
Copy Markdown
ContributorAuthor

@ThibsG@KodrAus I have addressed PR comment. Please take a look.

@KodrAus

Copy link
Copy Markdown
Contributor

Thanks @ayushmishra2005! This looks good to me.

@bors r+ rollup

@bors

bors commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 18f47d8 has been approved by KodrAus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2020
…ation_for_derived_Ord_PartialOrd, r=KodrAus
Corrected Misleading documentation for derived Ord/PartialOrd implementation
Corrected Misleading documentation for derived Ord/PartialOrd implementation
Fixesrust-lang#75620
@JohnTitorJohnTitor mentioned this pull request Aug 24, 2020
@JohnTitorJohnTitor mentioned this pull request Aug 24, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2020
Rollup of 10 pull requests
Successful merges:
- rust-lang#75819 (Use intra-doc-links in `core::{char, macros, fmt}`)
- rust-lang#75821 (Switch to intra-doc links in `std::macros`)
- rust-lang#75825 (Fix typo in documentation of i32 wrapping_abs())
- rust-lang#75826 (Corrected Misleading documentation for derived Ord/PartialOrd implementation )
- rust-lang#75831 (doc: Prefer https link for wikipedia URLs)
- rust-lang#75844 (publish-toolstate: show more context on HTTP error)
- rust-lang#75847 (Switch to intra-doc links in `std::collections`)
- rust-lang#75851 (Switch to intra-doc links in `core::array`)
- rust-lang#75856 (more tool clippy fixes)
- rust-lang#75859 (doc: Fix typo in std::process::Child documentation)
Failed merges:
r? @ghost
@bors
bors merged commit 427e969 into rust-lang:masterAug 24, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading documentation for derived Ord/PartialOrd implementation for enums

6 participants

@ayushmishra2005@rust-highfive@KodrAus@bors@ThibsG@cuviper