Uh oh!
There was an error while loading. Please reload this page.
Test that bounds checks are elided for [..index] after .position() - #75886
Merged
Conversation
rust-highfive
commented
Aug 24, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
This LLVM 11 has improved the performance of my Rust code significantly :-) Biggest jump since years. I don't know why yet. And investigating the causes isn't easy. |
tesuji
commented
Aug 25, 2020
Contributor
Can you extend the tests for |
tesuji
reviewed
Aug 25, 2020
Uh oh!
There was an error while loading. Please reload this page.
crlf0710
commented
Sep 12, 2020
Member
Mark-Simulacrum
commented
Sep 13, 2020
Member
I would like to see this changed to min-llvm-version: 11.0.0, as per the comment, and commits squashed. It might be good to also test that rposition() likewise optimizes, which it seems to on LLVM 11. |
erikdesjardins
commented
Sep 15, 2020
ContributorAuthor
@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review |
nikic
commented
Sep 15, 2020
Contributor
@bors r+ rollup |
bors
commented
Sep 15, 2020
Collaborator
📌 Commit 0f1d25e has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs) - rust-lang#75146 (Detect overflow in proc_macro_server subspan) - rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion) - rust-lang#75749 (Consolidate some duplicate code in the sys modules.) - rust-lang#75882 (Use translated variable for test string) - rust-lang#75886 (Test that bounds checks are elided for [..index] after .position()) - rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu) - rust-lang#76198 (Make some Ordering methods const) - rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0) - rust-lang#76763 (Update cargo) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#73396.
This was fixed by the LLVM 11 update in #73526.