Skip to content

Initial support for riscv32gc_unknown_linux_gnu - #76048

Merged
bors merged 4 commits into
rust-lang:masterfrom
alistair23:alistair/rv32-linux
Sep 16, 2020
Merged

Initial support for riscv32gc_unknown_linux_gnu#76048
bors merged 4 commits into
rust-lang:masterfrom
alistair23:alistair/rv32-linux

Conversation

@alistair23

@alistair23alistair23 commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

Now that RISC-V 32-bit (RV32) support is in upstream glibc let's add support for userspace Rust.

@rust-highfive

rust-highfive commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2020
@matthewjasper

matthewjasper commented Aug 30, 2020

Copy link
Copy Markdown
Contributor

cc @rust-lang/compiler

@bors

bors commented Aug 30, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

@alistair23
librustc_target: Initial support for riscv32gc_unknown_linux_gnu
a4183f0
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@jyn514jyn514 added O-riscv Target: RISC-V architecture O-x32 32 bit ABI for x86-64 labels Sep 15, 2020
@alistair23
librustc_target: Address comments
82bd5a3
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
jyn514
jyn514 reviewed Sep 15, 2020
View reviewed changes

@jyn514jyn514 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Alistair, good to see you again - this is the second RISCV PR I've reviewed 😄 https://gitlab.com/YottaDB/DB/YDB/-/merge_requests/777 oops, got that one mixed up with https://gitlab.com/YottaDB/DB/YDB/-/merge_requests/835

Comment threadsrc/librustc_target/spec/riscv32gc_unknown_linux_gnu.rs Outdated
@Dylan-DPC-zz

Dylan-DPC-zz commented Sep 15, 2020

Copy link
Copy Markdown

@alistair23 if you can resolve the conflicts, we can move this PR forward. Thanks :)

@Dylan-DPC-zzDylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@alistair23

alistair23 commented Sep 15, 2020

Copy link
Copy Markdown
ContributorAuthor

I have fixed the conflicts, I'm seeing some failures though. I'm assuming that's because we aren't using the latest glibc, but I can't figure out how to test that.

@Dylan-DPC-zzDylan-DPC-zz added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Sep 15, 2020•
edited
Loading

Copy link
Copy Markdown

i've created a zulip thread in case you need a place to ask help debugging the issue

@Amanieu

Amanieu commented Sep 15, 2020

Copy link
Copy Markdown
Member
 error: target `riscv32gc-unknown-linux-gnu` is missing from platform-support.md
If this is a new target, please add it to /checkout/src/doc/rustc/src/platform-support.md.

@davidtwco

davidtwco commented Sep 15, 2020

Copy link
Copy Markdown
Member

@rustbot ping risc-v

@rustbot

rustbot commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

Hey RISC-V Group! This bug has been identified as a good "RISC-V candidate".
In case it's useful, here are some instructions for tackling these sorts of
bugs. Maybe take a look?
Thanks! <3

cc @denisvasilik@Disasm@lenary@tblah

@Disasm

Disasm commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

@alistair23 could you add a line describing the target to src/doc/rustc/src/platform-support.md? There is already one for riscv64gc-unknown-linux-gnu which you can take as an example.

@alistair23
doc: platform-support.md: Document port
cbda154
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23

alistair23 commented Sep 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Done!

@alistair23
doc: platform-support.md: Move to tier 3
e968f86
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
jyn514
jyn514 reviewed Sep 15, 2020
View reviewed changes
Comment threadsrc/doc/rustc/src/platform-support.md Outdated
@jyn514jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2020
@Amanieu

Amanieu commented Sep 15, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e968f86 has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2020
@bors
Auto merge ofrust-lang#76771- Dylan-DPC:rollup-qj4j3ma, r=Dylan-DPC
f4e4485
Rollup of 10 pull requests
Successful merges:
- rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs)
- rust-lang#75146 (Detect overflow in proc_macro_server subspan)
- rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion)
- rust-lang#75749 (Consolidate some duplicate code in the sys modules.)
- rust-lang#75882 (Use translated variable for test string)
- rust-lang#75886 (Test that bounds checks are elided for [..index] after .position())
- rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu)
- rust-lang#76198 (Make some Ordering methods const)
- rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0)
- rust-lang#76763 (Update cargo)
Failed merges:
r? `@ghost`
@bors
bors merged commit db22898 into rust-lang:masterSep 16, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 16, 2020
@davidtwcodavidtwco mentioned this pull request Sep 20, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@matthewjaspermatthewjasper

Labels

O-riscvTarget: RISC-V architectureO-x3232 bit ABI for x86-64S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

10 participants

@alistair23@rust-highfive@matthewjasper@bors@Dylan-DPC-zz@Amanieu@davidtwco@rustbot@Disasm@jyn514