Uh oh!
There was an error while loading. Please reload this page.
Remove unused function - #76050
Merged
Merged
Conversation
rust-highfive
commented
Aug 29, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
matklad
commented
Aug 29, 2020
ContributorAuthor
petrochenkov
commented
Aug 29, 2020
Contributor
@bors r+ rollup |
bors
commented
Aug 29, 2020
Collaborator
📌 Commit 080fb8b8c63b4e61ba052138b0b7d75571aff317 has been approved by |
ContributorAuthor
bors r- Used in tests, that's why it wasn't caught by x.py check EDIT: I am moving those tests now. |
matklad
commented
Aug 29, 2020
ContributorAuthor
@bors r- |
matklad
commented
Aug 29, 2020
ContributorAuthor
Moved the tests, ready for review |
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Aug 29, 2020
Contributor
r=me with #76050 (comment) addressed |
matklad
commented
Aug 29, 2020
ContributorAuthor
@bors r=petrochenkov |
bors
commented
Aug 29, 2020
Collaborator
📌 Commit 5da8bf9501b18d2c4db2f81fec106bfc93e9d9f3 has been approved by |
StringReader is an intornal abstraction which at the moment changes a lot, so these unit tests cause quite a bit of friction. Moving them to rustc_lexer and more ingerated-testing style should make them much less annoying, hopefully without decreasing their usefulness much. Note that coloncolon tests are removed (it's unclear what those are testing). \r\n tests are removed as well, as we normalize line endings even before lexing.
matklad
commented
Aug 30, 2020
ContributorAuthor
Rebased over the great compiler renaming @bors r=petrochenkov |
bors
commented
Aug 30, 2020
Collaborator
📌 Commit 518cac9 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Aug 30, 2020
Remove unused function
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#75938 (Added some `min_const_generics` revisions into `const_generics` tests) - rust-lang#76050 (Remove unused function) - rust-lang#76075 (datastructures: replace `once_cell` crate with an impl from std) - rust-lang#76115 (Restore public visibility on some parsing functions for rustfmt) - rust-lang#76127 (rustbuild: Remove one LLD workaround) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.