Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #76159
Merged
Merged
Conversation
StringReader is an intornal abstraction which at the moment changes a lot, so these unit tests cause quite a bit of friction. Moving them to rustc_lexer and more ingerated-testing style should make them much less annoying, hopefully without decreasing their usefulness much. Note that coloncolon tests are removed (it's unclear what those are testing). \r\n tests are removed as well, as we normalize line endings even before lexing.
…visions, r=lcnr Added some `min_const_generics` revisions into `const_generics` tests Help in rust-lang#75279. still a lot more to cover though r? @lcnr
Remove unused function
… r=matklad datastructures: replace `once_cell` crate with an impl from std Fixesrust-lang#75700 r? @matklad We might need a perf run for this change.
…y, r=matklad Restore public visibility on some parsing functions for rustfmt In rust-lang#74826 the visibility of several parsing functions was reduced. However, rustfmt is an external consumer of some of these functions as well and needs the visibility to be public, similar to other elements in rustc_parse such as `parse_ident` https://github.com/rust-lang/rust/blob/db534b3ac286cf45688c3bbae6aa6e77439e52d2/src/librustc_parse/parser/mod.rs#L433-L436
rustbuild: Remove one LLD workaround The version of LLD shipped with Rust no longer have this issue. Closesrust-lang#68647
matklad
commented
Aug 31, 2020
ContributorAuthor
bors
commented
Aug 31, 2020
Collaborator
📌 Commit 9caf08f has been approved by |
bors
commented
Aug 31, 2020
Collaborator
bors
commented
Aug 31, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
min_const_genericsrevisions intoconst_genericstests #75938 (Added somemin_const_genericsrevisions intoconst_genericstests)once_cellcrate with an impl from std #76075 (datastructures: replaceonce_cellcrate with an impl from std)Failed merges:
r? @ghost