Uh oh!
There was an error while loading. Please reload this page.
Don't use zip to compare iterators during pretty-print hack - #76131
Merged
Conversation
rust-highfive
commented
Aug 30, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
Aaron1011force-pushed
the
fix/pretty-print-zip
branch
from
August 31, 2020 00:56
c70496a to
aa49ddbCompareAaron1011
commented
Sep 19, 2020
ContributorAuthor
@nikomatsakis: Are there any changes you'd like me to make? |
bors
commented
Sep 20, 2020
Collaborator
☔ The latest upstream changes (presumably #76964) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
lcnr
commented
Sep 21, 2020
Contributor
r? @lcnr r=me after rebase |
If the right-hand iterator has exactly one more element than the left-hand iterator, then both iterators will be fully consumed, but the extra element will never be compared.
Aaron1011force-pushed
the
fix/pretty-print-zip
branch
from
September 21, 2020 19:14
aa49ddb to
f5d71a9CompareAaron1011
commented
Sep 21, 2020
ContributorAuthor
@bors r=lcnr |
bors
commented
Sep 21, 2020
Collaborator
📌 Commit f5d71a9 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 22, 2020
Don't use `zip` to compare iterators during pretty-print hack If the right-hand iterator has exactly one more element than the left-hand iterator, then both iterators will be fully consumed, but the extra element will never be compared. Split out from rust-lang#76130
bors
commented
Sep 22, 2020
Collaborator
⌛ Testing commit f5d71a9 with merge ef973518ed1c8cbc4316637c6e4e53741551406d... |
ecstatic-morse added a commit
to ecstatic-morse/rust
that referenced
this pull request
Sep 22, 2020
Don't use `zip` to compare iterators during pretty-print hack If the right-hand iterator has exactly one more element than the left-hand iterator, then both iterators will be fully consumed, but the extra element will never be compared. Split out from rust-lang#76130
ecstatic-morse
commented
Sep 22, 2020
Contributor
@bors r- rollup Yield to rollup |
ecstatic-morse
commented
Sep 22, 2020
Contributor
@bors r=lcnr |
bors
commented
Sep 22, 2020
Collaborator
📌 Commit f5d71a9 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2020
…atic-morse Rollup of 13 pull requests Successful merges: - rust-lang#72734 (Reduce duplicate in liballoc reserve error handling) - rust-lang#76131 (Don't use `zip` to compare iterators during pretty-print hack) - rust-lang#76150 (Don't recommend ManuallyDrop to customize drop order) - rust-lang#76275 (Implementation of Write for some immutable ref structs) - rust-lang#76489 (Add explanation for E0756) - rust-lang#76581 (do not ICE on bound variables, return `TooGeneric` instead) - rust-lang#76655 (Make some methods of `Pin` unstable const) - rust-lang#76783 (Only get ImplKind::Impl once) - rust-lang#76807 (Use const-checking to forbid use of unstable features in const-stable functions) - rust-lang#76888 (use if let instead of single match arm expressions) - rust-lang#76914 (extend `Ty` and `TyCtxt` lints to self types) - rust-lang#77022 (Reduce boilerplate for BytePos and CharPos) - rust-lang#77032 (lint missing docs for extern items) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the right-hand iterator has exactly one more element than the
left-hand iterator, then both iterators will be fully consumed, but
the extra element will never be compared.
Split out from #76130