Skip to content

lint missing docs for extern items - #77032

Merged
bors merged 1 commit into
rust-lang:masterfrom
lcnr:visit-all-the-item-likes
Sep 22, 2020
Merged

lint missing docs for extern items#77032
bors merged 1 commit into
rust-lang:masterfrom
lcnr:visit-all-the-item-likes

Conversation

@lcnr

@lcnrlcnr commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

fixes#76991

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2020
@lcnr

lcnr commented Sep 21, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @davidtwco

@rust-highfiverust-highfive assigned davidtwco and unassigned eddybSep 21, 2020
@lcnr
lcnrforce-pushed the visit-all-the-item-likes branch from 235c95a to d452744CompareSeptember 21, 2020 22:03

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 21, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d452744 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2020
@dboyce-gh

Copy link
Copy Markdown

Where is check_foreign_item() called?

@jyn514jyn514 added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Sep 22, 2020
@tesuji

Copy link
Copy Markdown
Contributor

Where is check_foreign_item() called?

It is always called, just that's the default implementation on LateLintPass is empty, now it is overridden.

ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2020
…atic-morse
Rollup of 13 pull requests
Successful merges:
- rust-lang#72734 (Reduce duplicate in liballoc reserve error handling)
- rust-lang#76131 (Don't use `zip` to compare iterators during pretty-print hack)
- rust-lang#76150 (Don't recommend ManuallyDrop to customize drop order)
- rust-lang#76275 (Implementation of Write for some immutable ref structs)
- rust-lang#76489 (Add explanation for E0756)
- rust-lang#76581 (do not ICE on bound variables, return `TooGeneric` instead)
- rust-lang#76655 (Make some methods of `Pin` unstable const)
- rust-lang#76783 (Only get ImplKind::Impl once)
- rust-lang#76807 (Use const-checking to forbid use of unstable features in const-stable functions)
- rust-lang#76888 (use if let instead of single match arm expressions)
- rust-lang#76914 (extend `Ty` and `TyCtxt` lints to self types)
- rust-lang#77022 (Reduce boilerplate for BytePos and CharPos)
- rust-lang#77032 (lint missing docs for extern items)
Failed merges:
r? `@ghost`
@bors
bors merged commit 0863f9a into rust-lang:masterSep 22, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warn(missing_docs) doesn't trigger on extern declarations

9 participants

@lcnr@rust-highfive@davidtwco@bors@dboyce-gh@tesuji@eddyb@jyn514@rustbot