Skip to content

Reorder vec bench extend recycle - #76357

Closed
pickfire wants to merge 1 commit into
rust-lang:masterfrom
pickfire:patch-3
Closed

Reorder vec bench extend recycle#76357
pickfire wants to merge 1 commit into
rust-lang:masterfrom
pickfire:patch-3

Conversation

@pickfire

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2020
@jyn514

Copy link
Copy Markdown
Member

Can you describe why this is a useful change? It looks like it's just moving around code.

@jyn514jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 15, 2020
@pickfire

Copy link
Copy Markdown
ContributorAuthor

@jyn514 Yes, that's what I am doing here. I move it around to keep with similar code, all recycle bench are there but this one is alone, so lonely.

@bors

bors commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #77172) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@pickfire
pickfire deleted the patch-3 branch September 25, 2020 14:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pickfire@rust-highfive@jyn514@bors@joshtriplett