Skip to content

Reorder vec bench extend recycle - #77185

Closed
pickfire wants to merge 1 commit into
rust-lang:masterfrom
pickfire:patch-3
Closed

Reorder vec bench extend recycle#77185
pickfire wants to merge 1 commit into
rust-lang:masterfrom
pickfire:patch-3

Conversation

@pickfire

Copy link
Copy Markdown
Contributor

Superseeds #76357

r? @jyn514

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2020
@jyn514

Copy link
Copy Markdown
Member

I still don't really understand the point of this change.

@pickfire

pickfire commented Sep 25, 2020

Copy link
Copy Markdown
ContributorAuthor

Reordering the benchmark, if you look at the whole file you will understand. It just pops out randomly so I just make it easier to read.

@LeSeulArtichautLeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@Dylan-DPC-zz

Copy link
Copy Markdown

Looks like there is no motivation for this pr and don't want to end up with dozens of pr reordering benchmarks :P

@pickfire
pickfire deleted the patch-3 branch October 17, 2020 07:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pickfire@jyn514@Dylan-DPC-zz@rust-highfive@LeSeulArtichaut