Skip to content

Point at named argument not found when using format_args_capture instead of whole format string - #76485

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:format_arg_capture_spans
Sep 26, 2020
Merged

Point at named argument not found when using format_args_capture instead of whole format string#76485
bors merged 1 commit into
rust-lang:masterfrom
estebank:format_arg_capture_spans

Conversation

@estebank

@estebankestebank commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2020
@jyn514jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2020
@crlf0710

crlf0710 commented Sep 25, 2020

Copy link
Copy Markdown
Member

r? @davidtwco

davidtwco
davidtwco approved these changes Sep 25, 2020
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco

davidtwco commented Sep 25, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2ac89ff has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2020
This was referenced Sep 25, 2020
Closed
Closed
@jonas-schievinkjonas-schievink mentioned this pull request Sep 26, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 26, 2020
@RalfJung
Rollup merge ofrust-lang#76485- estebank:format_arg_capture_spans, …
bc9c67f
…r=davidtwco
Point at named argument not found when using `format_args_capture` instead of whole format string
@RalfJungRalfJung mentioned this pull request Sep 26, 2020
Closed
@bors

bors commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2ac89ff with merge 6f9a8a7...

@bors

bors commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 6f9a8a7 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2020
@bors
bors merged commit 6f9a8a7 into rust-lang:masterSep 26, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 26, 2020
@estebank
estebank deleted the format_arg_capture_spans branch November 9, 2023 05:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes
+1 more reviewer
@jyn514jyn514jyn514 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwcodavidtwco

Labels

A-diagnosticsArea: Messages for errors, warnings, and lintsmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

8 participants

@estebank@rust-highfive@crlf0710@davidtwco@bors@jyn514@nikomatsakis@rustbot