Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #77222
Closed
RalfJung wants to merge 39 commits into
Closed
Conversation
Triggered by a discussion on wg-unsafe-code-guidelines about which layouts of `Option<T>` one can guarantee are optimised to a single pointer.
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Ralf Jung <post@ralfj.de>
…stead of whole format string
The main use case of TrustedLen is allowing APIs to specialize on it, but no use of it uses that specialization. Instead, only the .len() function provided by ExactSizeIterator is used, which is already required to be accurate. Thus, the TrustedLen requirement on BuilderMethods::switch is redundant.
This refactors handling of `Rvalue::{Unary,Binary}Op` in the
const-checker. Now we `span_bug` if there's an unexpected type in a
primitive operation. This also allows unary negation on
`char` values through the const-checker because it makes the code a bit
cleaner. `char` does not actually support these operations, and if it
did, we could evaluate them at compile-time.It's called `span` elsewhere in the compiler and `span` is also less surprising. `whence` is whimsical, but not super clear :)
…es, r=dtolnay Explicitly document the size guarantees that Option makes. Triggered by a discussion on wg-unsafe-code-guidelines about which layouts of `Option<T>` one can guarantee are optimised to a single pointer. CC @RalfJung
…r=davidtwco Point at named argument not found when using `format_args_capture` instead of whole format string
…s-slice-iter, r=Dylan-DPC Add missing code examples on slice iter types r? @Dylan-DPC
…r=varkor merge `need_type_info_err(_const)` I hoped that this would automatically solve rust-lang#76737 but it doesn't quite seem like it fixesrust-lang#77092 r? @varkor
… r=RalfJung,oli-obk Add `#![feature(const_fn_floating_point_arithmetic)]` cc rust-lang#76618 This is a template for splitting up `const_fn` into granular feature gates. I think this will make it easier, both for us and for users, to track stabilization of each individual feature. We don't *have* to do this, however. We could also keep stabilizing things out from under `const_fn`. cc @rust-lang/wg-const-eval r? @oli-obk
…petrochenkov Remove TrustedLen requirement from BuilderMethods::switch The main use case of TrustedLen is allowing APIs to specialize on it, but no use of it uses that specialization. Instead, only the .len() function provided by ExactSizeIterator is used, which is already required to be accurate. Thus, the TrustedLen requirement on BuilderMethods::switch is redundant.
Remove stray word from `ClosureKind::extends` docs
Rename `whence` to `span` It's called `span` elsewhere in the compiler and `span` is also less surprising. `whence` is whimsical, but not super clear :) See [this Discord conversation](https://discord.com/channels/442252698964721669/459149231702278154/758731658689511444) for more. r? @jyn514
Remove unused #[allow(...)] statements from compiler/
RalfJung
commented
Sep 26, 2020
MemberAuthor
bors
commented
Sep 26, 2020
Collaborator
📌 Commit 644b592 has been approved by |
bors
commented
Sep 26, 2020
Collaborator
⌛ Testing commit 644b592 with merge 3b3d9237b6c6388f27989b03b471830610bc0aad... |
This comment has been minimized.
This comment has been minimized.
RalfJung
commented
Sep 26, 2020
MemberAuthor
(PR CI failure is a network issue) |
bors
commented
Sep 26, 2020
Collaborator
💔 Test failed - checks-actions |
RalfJung
commented
Sep 26, 2020
MemberAuthor
Another network failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
format_args_captureinstead of whole format string #76485 (Point at named argument not found when usingformat_args_captureinstead of whole format string)need_type_info_err(_const)#77093 (mergeneed_type_info_err(_const))#![feature(const_fn_floating_point_arithmetic)]#77122 (Add#![feature(const_fn_floating_point_arithmetic)])ClosureKind::extendsdocs #77204 (Remove stray word fromClosureKind::extendsdocs)whencetospan#77207 (Renamewhencetospan)Failed merges:
#[rustc_allow_const_fn_ptr]and add#![feature(const_fn_fn_ptr_basics)]#77170 (Remove#[rustc_allow_const_fn_ptr]and add#![feature(const_fn_fn_ptr_basics)])r? @ghost