Skip to content

Do not lint ignored private doc tests - #76642

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:ignored-private-doc-test
Sep 16, 2020
Merged

Do not lint ignored private doc tests#76642
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:ignored-private-doc-test

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes#76457.

r? @ehuss

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2020
@jyn514jyn514 added A-doctests Area: Documentation tests, run by rustdoc A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 12, 2020
Comment threadsrc/librustdoc/passes/calculate_doc_coverage.rs Outdated
Comment threadsrc/test/rustdoc-ui/private-doc-test.rs Outdated
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Updated!

@jyn514

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 15d25a8 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 16, 2020
@bors

bors commented Sep 16, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15d25a8 with merge c8516b706a683ebb7154b89993b15e684b7bbe0a...

@jyn514jyn514 changed the title Ignored private doc testDo not lint ignored private doc testsSep 16, 2020
@bors

bors commented Sep 16, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2020
@ehuss

Copy link
Copy Markdown
Contributor

@bors retry
azure macos hung and timed out

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2020
@tmandrytmandry mentioned this pull request Sep 16, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2020
Rollup of 16 pull requests
Successful merges:
- rust-lang#75026 (Add array_windows fn)
- rust-lang#76642 (Do not lint ignored private doc tests)
- rust-lang#76719 (Change error message for ty param in const)
- rust-lang#76721 (Use intra-doc links in `core::mem`)
- rust-lang#76728 (Add a comment why `extern crate` is necessary for rustdoc)
- rust-lang#76735 (Remove unnecessary `clone()`s in bootstrap)
- rust-lang#76741 (Avoid printing dry run timings)
- rust-lang#76747 (Add missing code examples in libcore)
- rust-lang#76756 (fix a couple of stylistic clippy warnings)
- rust-lang#76758 ([fuchsia] Propagate the userspace UTC clock)
- rust-lang#76759 (Fix stabilization marker for future_readiness_fns)
- rust-lang#76760 (don't lazily evaluate some trivial values for Option::None replacements (clippy::unnecessary_lazy_evaluations))
- rust-lang#76764 (Update books)
- rust-lang#76775 (Strip a single leading tab when rendering dataflow diffs)
- rust-lang#76778 (Simplify iter fuse struct doc)
- rust-lang#76794 (Make graphviz font configurable)
Failed merges:
r? `@ghost`
@bors
bors merged commit ece688b into rust-lang:masterSep 16, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 16, 2020
@GuillaumeGomez
GuillaumeGomez deleted the ignored-private-doc-test branch September 16, 2020 22:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-doctestsArea: Documentation tests, run by rustdocA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc: private_doc_tests lint ignores "ignore"

6 participants

@GuillaumeGomez@jyn514@bors@ehuss@rust-highfive@rustbot