Uh oh!
There was an error while loading. Please reload this page.
Rollup of 16 pull requests - #76804
Merged
Merged
Conversation
* Change error message for type param in a const expression when using min_const_generics * Change ParamInNonTrivialAnonConst to contain an extra bool used for distinguishing whether the passed-in symbol is a type or a value.
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
namely: clippy::redundant_pattern_matching clippy::redundant_pattern clippy::search_is_some clippy::filter_next clippy::into_iter_on_ref clippy::clone_on_copy clippy::needless_return
On Fuchsia, spawning a subprocess does not automatically clone all of the parent process' capabilities. UTC time on Fuchsia is managed by a top-level userspace clock capability that is cloned and passed to subprocesses. This change ensures that any Rust subprocess gets access to the UTC clock, if the parent had access to it. This is critical for tests, which on Fuchsia, use panic=abort and spawn subprocesses per test.
Moved it from 1.47.0 -> 1.48.0, which is the correct release for this to stabilize in
…ts (clippy::unnecessary_lazy_evaluations)
The performance difference is negligible, but it makes me feel better. Note that this does not remove some clones in `config`, because it would require changing the logic around (and performance doesn't matter for bootstrap).
Updated issue to rust-lang#75027 Update to rm oob access And hopefully fix docs as well Fixed naming conflict in test Fix test which used 1-indexing Nth starts from 0, woops Fix a bunch of off by 1 errors See https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=757b311987e3fae1ca47122969acda5a Add even more off by 1 errors And also write `next` and `next_back` in terms of `nth` and `nth_back`. Run fmt Fix forgetting to change fn name in test add nth_back test & document unsafe Remove as_ref().unwrap() Documented occurrences of unsafe, noting what invariants are maintained
Alternative to PR #rust-lang#76776. To change the graphviz output to use an alternative `fontname` value, add a command line option like: `rustc --graphviz-font=monospace`.
Overrides the debugging_opts.graphviz_font setting.
Add array_windows fn This mimicks the functionality added by array_chunks, and implements a const-generic form of `windows`. It makes egregious use of `unsafe`, but by necessity because the array must be re-interpreted as a slice of arrays, and unlike array_chunks this cannot be done by casting the original array once, since each time the index is advanced it needs to move one element, not `N`. I'm planning on adding more tests, but this should be good enough as a premise for the functionality. Notably: should there be more functions overwritten for the iterator implementation/in general? ~~I've marked the issue as rust-lang#74985 as there is no corresponding exact issue for `array_windows`, but it's based of off `array_chunks`.~~ Edit: See Issue rust-lang#75027 created by @lcnr for tracking issue ~~Do not merge until I add more tests, please.~~ r? @lcnr
…test, r=jyn514 Do not lint ignored private doc tests Fixesrust-lang#76457. r? @ehuss
… r=lcnr Change error message for ty param in const This PR introduces the following changes: * Change error message for type param in a const expression when using `min_const_generics` * Change `ParamInNonTrivialAnonConst` to contain an extra `bool` used for distinguishing whether the passed-in symbol is a type or a value. Fixesrust-lang#76701
…m, r=jyn514 Use intra-doc links in `core::mem` Part of rust-lang#75080. Last one for now! --- @rustbot modify labels: A-intra-doc-links T-doc
Add a comment why `extern crate` is necessary for rustdoc r? @ehuss From rust-lang#74293 (comment).
Remove unnecessary `clone()`s in bootstrap The performance difference is negligible, but it makes me feel better. r? @Mark-Simulacrum
…r=alexcrichton Avoid printing dry run timings This avoids a wall of text on CI with 0.000 as the likely time. r? @alexcrichton
…-code-examples, r=Mark-Simulacrum Add missing code examples in libcore
fix a couple of stylistic clippy warnings namely: clippy::redundant_pattern_matching clippy::redundant_pattern clippy::search_is_some clippy::filter_next clippy::into_iter_on_ref clippy::clone_on_copy clippy::needless_return
[fuchsia] Propagate the userspace UTC clock On Fuchsia, spawning a subprocess does not automatically clone all of the parent process' capabilities. UTC time on Fuchsia is managed by a top-level userspace clock capability that is cloned and passed to subprocesses. This change ensures that any Rust subprocess gets access to the UTC clock, if the parent had access to it. This is critical for tests, which on Fuchsia, use panic=abort and spawn subprocesses per test.
…y-stabilization-label, r=Dylan-DPC Fix stabilization marker for future_readiness_fns Updated the rustc version in which this will be stabilized from `1.47.0 -> 1.48.0`. Fixesrust-lang#74328 (comment). Ref rust-lang#70921. r? @Dylan-DPC
…rkor don't lazily evaluate some trivial values for Option::None replacements (clippy::unnecessary_lazy_evaluations)
Update books ## nomicon 1 commits in 25854752549d44d76fbd7650e17cb4f167a0b8fb..6e57e64501f61873ab80cb78a07180a22751a5d6 2020-08-19 16:41:48 -0400 to 2020-09-14 11:40:23 -0400 - Fix API change to alloc::Global::grow. (rust-lang/nomicon#236) ## reference 3 commits in 25391dba46262f882fa846beefaff54a966a8fa5..56a13c082ee90736c08d6abdcd90462517b703d3 2020-09-02 07:22:55 -0700 to 2020-09-14 23:20:16 -0700 - Update the description of staticlib (rust-lang/reference#884) - Rust 1.46 now allows more features in const fn (rust-lang/reference#883) - Document the enum changes in RFC 2195 (rust-lang/reference#879) ## book 1 commits in e5ed97128302d5fa45dbac0e64426bc7649a558c..cb28dee95e5e50b793e6ba9291c5d1568d3ad72e 2020-08-31 12:53:40 -0500 to 2020-09-09 10:06:00 -0500 - Fixed the error message of invalid array element access in ch03.2 (rust-lang/book#2446)
…iff, r=Mark-Simulacrum Strip a single leading tab when rendering dataflow diffs The `fmt_diff_with` formatter uses a tab to separate additions from subtractions. Strip it when rendering those diffs on separate lines. r? @Mark-Simulacrum (since you're speedy)
Simplify iter fuse struct doc
…-morse Make graphviz font configurable Alternative to PR rust-lang#76776. To change the graphviz output to use an alternative `fontname` value, add a command line option like: `rustc --graphviz-font=monospace`. r? @ecstatic-morse
tmandry
commented
Sep 16, 2020
MemberAuthor
bors
commented
Sep 16, 2020
Collaborator
📌 Commit 3bf66ae has been approved by |
bors
commented
Sep 16, 2020
Collaborator
bors
commented
Sep 16, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
commented
Sep 16, 2020
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Sep 16, 2020
Tested on commit rust-lang/rust@285fc7d. Direct link to PR: <rust-lang/rust#76804> 🎉 nomicon on windows: test-fail → test-pass (cc @Gankra@frewsxcv). 🎉 nomicon on linux: test-fail → test-pass (cc @Gankra@frewsxcv).
This was referenced Sep 16, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::mem#76721 (Use intra-doc links incore::mem)extern crateis necessary for rustdoc #76728 (Add a comment whyextern crateis necessary for rustdoc)clone()s in bootstrap #76735 (Remove unnecessaryclone()s in bootstrap)Failed merges:
r? @ghost