Skip to content

Test and reject out-of-bounds shuffle vectors - #76768

Merged
bors merged 3 commits into
rust-lang:masterfrom
workingjubilee:reject-oob-shuffles
Oct 4, 2020
Merged

Test and reject out-of-bounds shuffle vectors#76768
bors merged 3 commits into
rust-lang:masterfrom
workingjubilee:reject-oob-shuffles

Conversation

@workingjubilee

@workingjubileeworkingjubilee commented Sep 15, 2020

Copy link
Copy Markdown
Member

Fixes#73542.

@rust-highfive

rust-highfive commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2020
@jyn514jyn514 added A-SIMD Area: SIMD (Single Instruction Multiple Data) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2020
@jyn514

jyn514 commented Sep 16, 2020

Copy link
Copy Markdown
Member

r? @RalfJung

@RalfJung

RalfJung commented Sep 16, 2020

Copy link
Copy Markdown
Member

Thanks, this looks good!

Is simd_shuffle4 the only intrinsic that needs such a check?

@workingjubilee

workingjubilee commented Sep 16, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Well, I can macro the test over the various other LLVM shuffle intrinsics. It didn't seem immediately necessary because they would all follow the pattern, so I figured any old canary would tell us how it is in the coalmine. But there are actually a few other tests for this floating in the compiler that verify this error code is emitted (since it basically exists for this issue). As far as I can tell, it would be only the shuffles, and maybe insert/extract, that could apply out-of-bounds logic in the first place.

@RalfJung

RalfJung commented Sep 16, 2020

Copy link
Copy Markdown
Member

Yeah, would be good to have all intrinsic bounds checks covered here. Canaries are great but without knowing how the check works internally it is easy to think one has covered all code paths but forget about some odd special case...

When I grep for that error code, most existing tests seem to be about other aspects? In fact I can see none that says anything about "out of bounds". The test should cover all intrinsics that can have that particular error. The error code is for all sorts of problems with intrinsics.

@workingjubilee

workingjubilee commented Sep 16, 2020

Copy link
Copy Markdown
MemberAuthor

That's completely fair, will generalize this fully then (and figure out if insert/extract can go OOB... if they can, I'll include them).

@RalfJungRalfJung added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2020
@RalfJung

RalfJung commented Sep 27, 2020

Copy link
Copy Markdown
Member

That's completely fair, will generalize this fully then (and figure out if insert/extract can go OOB... if they can, I'll include them).

@workingjubilee From what I can see, this is still outstanding.

@workingjubilee

workingjubilee commented Oct 3, 2020

Copy link
Copy Markdown
MemberAuthor

Indeed it was!

@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2020
@workingjubilee

workingjubilee commented Oct 3, 2020

Copy link
Copy Markdown
MemberAuthor

Force pushes were tidy thrash, whoops.

RalfJung
RalfJung reviewed Oct 3, 2020
View reviewed changes
Comment threadsrc/test/ui/simd/shuffle-not-out-of-bounds.rs Outdated
@RalfJung

RalfJung commented Oct 3, 2020

Copy link
Copy Markdown
Member

r=me with or without //~|.

@jyn514jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2020
@workingjubilee

workingjubilee commented Oct 3, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r=RalfJung
does this work? :^)
@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review if not

@rustbot

rustbot commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

Error: Label if can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@bors

bors commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

@workingjubilee: 🔑 Insufficient privileges: Not in reviewers

@workingjubilee

workingjubilee commented Oct 3, 2020

Copy link
Copy Markdown
MemberAuthor

RIP me. 💦

@jyn514

jyn514 commented Oct 3, 2020

Copy link
Copy Markdown
Member

@bors r=ralfjung rollup

@bors

bors commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2fcd183 has been approved by ralfjung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2020
@RalfJung

RalfJung commented Oct 3, 2020

Copy link
Copy Markdown
Member

RIP me. sweat_drops

Sorry -- next time I'll let bors know that you can do this. :)

@JohnTitorJohnTitor mentioned this pull request Oct 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2020
@bors
Auto merge ofrust-lang#77517- JohnTitor:rollup-msbd49e, r=JohnTitor
2251766
Rollup of 11 pull requests
Successful merges:
- rust-lang#75143 (Use `tracing` spans to trace the entire MIR interp stack)
- rust-lang#75699 (Uplift drop-bounds lint from clippy)
- rust-lang#76768 (Test and reject out-of-bounds shuffle vectors)
- rust-lang#77190 (updated p! macro to accept literals)
- rust-lang#77388 (Add some regression tests)
- rust-lang#77419 (Create E0777 error code for invalid argument in derive)
- rust-lang#77447 (BTreeMap: document DrainFilterInner better)
- rust-lang#77468 (Fix test name)
- rust-lang#77469 (Improve rustdoc error for failed intra-doc link resolution)
- rust-lang#77473 (Make --all-targets in x.py check opt-in)
- rust-lang#77508 (Fix capitalization in blog post name)
Failed merges:
r? `@ghost`
@bors
bors merged commit 65e4488 into rust-lang:masterOct 4, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 4, 2020
@workingjubileeworkingjubilee mentioned this pull request Feb 5, 2021
Merged
@workingjubilee
workingjubilee deleted the reject-oob-shuffles branch April 23, 2021 19:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

Assignees

@RalfJungRalfJung

Labels

A-SIMDArea: SIMD (Single Instruction Multiple Data)A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

Reject OOB shufflevector intrinsics

7 participants

@workingjubilee@rust-highfive@jyn514@RalfJung@rustbot@bors@Mark-Simulacrum