Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #77517
Merged
Merged
Conversation
Remove trailing `-`.
The previous error was confusing since it made it sound like you can't link to items that are defined outside the current module. Also suggested importing the item.
The new error was confusing when there was partial resolution (something like `std::io::nonexistent`); the old one is better for those cases.
This matches Cargo behavior and avoids the (somewhat expensive) double checking, as well as the unfortunate duplicate error messages (rust-lang#76822, rust-lang/cargo#5128).
Use `tracing` spans to trace the entire MIR interp stack r? @RalfJung While being very verbose, this allows really good tracking of what's going on. While I considered schemes like the previous indenter that we had (which we could get by using the `tracing-tree` crate), this will break down horribly with things like multithreaded rustc. Instead, we can now use `RUSTC_LOG` to restrict the things being traced. You could specify a filter in a way that only shows the logging of a specific frame.  If we lower the span's level to `debug`, then in `info` level logging we'd not see the frames, but in `debug` level we would see them. The filtering rules in `tracing` are super powerful, but I'm not sure if we can specify a filter so we do see `debug` level events, but *not* the `frame` spans. The documentation at https://docs.rs/tracing-subscriber/0.2.10/tracing_subscriber/struct.EnvFilter.html makes me think that we can only turn on things, not turn off things at a more precise level. cc @hawkw
…chenkov Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.
… r=ralfjung Test and reject out-of-bounds shuffle vectors Fixesrust-lang#73542.
updated p! macro to accept literals Closesrust-lang#70948 Huge thanks @eddyb for helping me out!
Add some regression tests Closesrust-lang#66501Closesrust-lang#68951Closesrust-lang#72565Closesrust-lang#74244Closesrust-lang#75299 The first issue is fixed in 1.43.0, other issues are fixed in the recent nightly.
Create E0777 error code for invalid argument in derive The second commit is to fix a nit reported by @jyn514 [here](https://github.com/rust-lang/rust/pull/76406/files#r485186592).
…ulacrum BTreeMap: document DrainFilterInner better r? @Mark-Simulacrum
Fix test name Remove trailing `-`.
…rror, r=jyn514 Improve rustdoc error for failed intra-doc link resolution The previous error was confusing since it made it sound like you can't link to items that are defined outside the current module. Also suggested importing the item. r? @jyn514
…static-morse Make --all-targets in x.py check opt-in In particular due to rust-lang#76822, making this the default is currently suboptimal. r? @ecstatic-morse
Fix capitalization in blog post name
JohnTitor
commented
Oct 4, 2020
MemberAuthor
bors
commented
Oct 4, 2020
Collaborator
📌 Commit f5db166 has been approved by |
bors
commented
Oct 4, 2020
Collaborator
bors
commented
Oct 4, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Oct 4, 2020
This was referenced Oct 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
tracingspans to trace the entire MIR interp stack #75143 (Usetracingspans to trace the entire MIR interp stack)Failed merges:
r? @ghost